Attention is currently required from: Hung-Te Lin, Jarried Lin, Yu-Ping Wu, Zhaoqing Jiu.
Paul Menzel has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/86552?usp=email )
The change is no longer submittable: All-Comments-Resolved is unsatisfied now.
Change subject: soc/mediatek/mt8196: Adjust thermal trip point parameters
......................................................................
Patch Set 3:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/86552/comment/5fe0a6fa_63b667ed?usp... :
PS3, Line 9: Adjust thermal trip point parameters so the thermal can trigger the interrupt at the expected trip point.
Please re-flow for 72 characters per line.
https://review.coreboot.org/c/coreboot/+/86552/comment/7a581a6c_e370bd04?usp... :
PS3, Line 10:
Why are the new values correct?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/86552?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ia7361edd7f75b82fff4241ec94488ed1ef07346f
Gerrit-Change-Number: 86552
Gerrit-PatchSet: 3
Gerrit-Owner: Jarried Lin
jarried.lin@mediatek.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Yidi Lin
yidilin@google.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Zhaoqing Jiu
zhaoqing.jiu@mediatek.corp-partner.google.com
Gerrit-Attention: Hung-Te Lin
hungte@chromium.org
Gerrit-Attention: Zhaoqing Jiu
zhaoqing.jiu@mediatek.corp-partner.google.com
Gerrit-Attention: Jarried Lin
jarried.lin@mediatek.com
Gerrit-Attention: Yu-Ping Wu
yupingso@google.com
Gerrit-Comment-Date: Sat, 22 Feb 2025 06:18:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No