build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/28697 )
Change subject: drivers/spi/winbond: Add function to lock flash's status register ......................................................................
Patch Set 1:
(6 comments)
https://review.coreboot.org/#/c/28697/1/src/drivers/spi/winbond.c File src/drivers/spi/winbond.c:
https://review.coreboot.org/#/c/28697/1/src/drivers/spi/winbond.c@552 PS1, Line 552: val = (union status_reg1_bp3){ .srp0 = !!(mode & 1) }.u; space required after that close brace '}'
https://review.coreboot.org/#/c/28697/1/src/drivers/spi/winbond.c@553 PS1, Line 553: mask = (union status_reg1_bp3){ .srp0 = 1 }.u; space required after that close brace '}'
https://review.coreboot.org/#/c/28697/1/src/drivers/spi/winbond.c@555 PS1, Line 555: val = (union status_reg1_bp4){ .srp0 = !!(mode & 1) }.u; space required after that close brace '}'
https://review.coreboot.org/#/c/28697/1/src/drivers/spi/winbond.c@556 PS1, Line 556: mask = (union status_reg1_bp4){ .srp0 = 1 }.u; space required after that close brace '}'
https://review.coreboot.org/#/c/28697/1/src/drivers/spi/winbond.c@563 PS1, Line 563: val = (union status_reg2){ .srp1 = !!(mode & 2) }.u; space required after that close brace '}'
https://review.coreboot.org/#/c/28697/1/src/drivers/spi/winbond.c@564 PS1, Line 564: mask = (union status_reg2){ .srp1 = 1 }.u; space required after that close brace '}'