Change in coreboot[master]: mb/system76/lemp9: enable I2C HID touchpad

List overview All Threads
Download

newer

older

Change in libgfxinit[master]:...

Change in coreboot[master]:...

Jeremy Soller (Code Review)

20 Jul 2020 20 Jul '20

11:32 p.m.

Jeremy Soller has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/43623 )

Change subject: mb/system76/lemp9: enable I2C HID touchpad ......................................................................

mb/system76/lemp9: enable I2C HID touchpad

Tested on lemp9, touchpad confirmed to use I2C HID

Signed-off-by: Jeremy Soller jeremy@system76.com Change-Id: Ic3a90fda134b1d53f28ab687b3033ec52fee843b --- M src/mainboard/system76/lemp9/Kconfig M src/mainboard/system76/lemp9/devicetree.cb M src/mainboard/system76/lemp9/gpio.h 3 files changed, 34 insertions(+), 3 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/23/43623/1

diff --git a/src/mainboard/system76/lemp9/Kconfig b/src/mainboard/system76/lemp9/Kconfig index dd5359e..c606d91 100644 --- a/src/mainboard/system76/lemp9/Kconfig +++ b/src/mainboard/system76/lemp9/Kconfig @@ -3,6 +3,7 @@ config BOARD_SPECIFIC_OPTIONS def_bool y select BOARD_ROMSIZE_KB_16384 + select DRIVERS_I2C_HID select EC_SYSTEM76_EC select HAVE_ACPI_RESUME select HAVE_ACPI_TABLES diff --git a/src/mainboard/system76/lemp9/devicetree.cb b/src/mainboard/system76/lemp9/devicetree.cb index 25ae62f..27f5efb 100644 --- a/src/mainboard/system76/lemp9/devicetree.cb +++ b/src/mainboard/system76/lemp9/devicetree.cb @@ -2,6 +2,11 @@ # Lock Down register "common_soc_config" = "{ .chipset_lockdown = CHIPSET_LOCKDOWN_COREBOOT, + .i2c[0] = { + .speed = I2C_SPEED_FAST, + .rise_time_ns = 80, + .fall_time_ns = 110, + }, }"

# Send an extra VR mailbox command for the PS4 exit issue @@ -35,6 +40,22 @@ #register "enable_c6dram" = "1"

# FSP Silicon (soc/intel/cannonlake/fsp_params.c) + # Serial I/O + register "SerialIoDevMode" = "{ + [PchSerialIoIndexI2C0] = PchSerialIoPci, + [PchSerialIoIndexI2C1] = PchSerialIoDisabled, + [PchSerialIoIndexI2C2] = PchSerialIoPci, + [PchSerialIoIndexI2C3] = PchSerialIoDisabled, + [PchSerialIoIndexI2C4] = PchSerialIoDisabled, + [PchSerialIoIndexI2C5] = PchSerialIoDisabled, + [PchSerialIoIndexSPI0] = PchSerialIoDisabled, + [PchSerialIoIndexSPI1] = PchSerialIoDisabled, + [PchSerialIoIndexSPI2] = PchSerialIoDisabled, + [PchSerialIoIndexUART0] = PchSerialIoDisabled, + [PchSerialIoIndexUART1] = PchSerialIoDisabled, + [PchSerialIoIndexUART2] = PchSerialIoPci, + }" + # SATA register "SataMode" = "Sata_AHCI" register "SataSalpSupport" = "0" @@ -194,7 +215,16 @@ device pci 14.3 on end # CNVi wifi #end device pci 14.5 off end # SDCard - device pci 15.0 off end # I2C #0 + device pci 15.0 on + chip drivers/i2c/hid + register "generic.hid" = ""PNP0C50"" + register "generic.desc" = ""ELAN Touchpad"" + register "generic.irq" = "ACPI_IRQ_EDGE_LOW(GPP_B3_IRQ)" + register "generic.probed" = "1" + register "hid_desc_reg_offset" = "0x01" + device i2c 15 on end + end + end # I2C #0 device pci 15.1 off end # I2C #1 device pci 15.2 off end # I2C #2 device pci 15.3 off end # I2C #3 diff --git a/src/mainboard/system76/lemp9/gpio.h b/src/mainboard/system76/lemp9/gpio.h index d06145d..e71197c 100644 --- a/src/mainboard/system76/lemp9/gpio.h +++ b/src/mainboard/system76/lemp9/gpio.h @@ -139,8 +139,8 @@ PAD_CFG_NC(GPP_B2),

// CPU Misc - // GPP_B3 - _PAD_CFG_STRUCT(GPP_B3, 0x80100100, 0x0000), + // GPP_B3 (touchpad interrupt) + PAD_CFG_GPI_APIC(GPP_B3, NONE, PLTRST, EDGE_SINGLE, INVERT), // NC PAD_CFG_NC(GPP_B4),

Attachments:

attachment.htm (text/html — 7.3 KB)

Show replies by date

Angel Pons (Code Review)

20 Jul 20 Jul

11:39 p.m.

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43623 )

Change subject: mb/system76/lemp9: enable I2C HID touchpad ......................................................................

Patch Set 1: Code-Review+1

(3 comments)

https://review.coreboot.org/c/coreboot/+/43623/1//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/43623/1//COMMIT_MSG@9 PS1, Line 9: Tested on lemp9, touchpad confirmed to use I2C HID "confirmed to use I2C HID"? What do you mean?

Also add a trailing period.

https://review.coreboot.org/c/coreboot/+/43623/1/src/mainboard/system76/lemp... File src/mainboard/system76/lemp9/devicetree.cb:

https://review.coreboot.org/c/coreboot/+/43623/1/src/mainboard/system76/lemp... PS1, Line 47: PchSerialIoPci What's here?

https://review.coreboot.org/c/coreboot/+/43623/1/src/mainboard/system76/lemp... PS1, Line 56: PchSerialIoPci And here? (looks like it was enabled on the devicetree before)

Jeremy Soller (Code Review)

11:53 p.m.

Hello build bot (Jenkins), Angel Pons,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/43623

to look at the new patch set (#2).

Change subject: mb/system76/lemp9: enable I2C HID touchpad ......................................................................

mb/system76/lemp9: enable I2C HID touchpad

Tested on lemp9, touchpad confirmed to use i2c-hid driver in Linux instead of ps/2.

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/23/43623/2

Jeremy Soller (Code Review)

11:56 p.m.

Hello build bot (Jenkins), Angel Pons,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/43623

to look at the new patch set (#3).

Change subject: mb/system76/lemp9: enable I2C HID touchpad ......................................................................

mb/system76/lemp9: enable I2C HID touchpad

Tested on lemp9, touchpad confirmed to use i2c-hid driver in Linux instead of ps/2.

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/23/43623/3

Angel Pons (Code Review)

11:59 p.m.

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43623 )

Change subject: mb/system76/lemp9: enable I2C HID touchpad ......................................................................

Patch Set 4: Code-Review+1

(4 comments)

https://review.coreboot.org/c/coreboot/+/43623/1//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/43623/1//COMMIT_MSG@9 PS1, Line 9: Tested on lemp9, touchpad confirmed to use I2C HID

...

"confirmed to use I2C HID"? What do you mean? […]

Done

https://review.coreboot.org/c/coreboot/+/43623/4//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/43623/4//COMMIT_MSG@10 PS4, Line 10: ps/2 nit: PS/2

https://review.coreboot.org/c/coreboot/+/43623/1/src/mainboard/system76/lemp... File src/mainboard/system76/lemp9/devicetree.cb:

https://review.coreboot.org/c/coreboot/+/43623/1/src/mainboard/system76/lemp... PS1, Line 47: PchSerialIoPci

...

What's here?

Done

https://review.coreboot.org/c/coreboot/+/43623/1/src/mainboard/system76/lemp... PS1, Line 56: PchSerialIoPci

...

And here? (looks like it was enabled on the devicetree before)

Done

-- To view, visit https://review.coreboot.org/c/coreboot/+/43623 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic3a90fda134b1d53f28ab687b3033ec52fee843b Gerrit-Change-Number: 43623 Gerrit-PatchSet: 4 Gerrit-Owner: Jeremy Soller jeremy@system76.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Mon, 20 Jul 2020 21:59:12 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Angel Pons th3fanbus@gmail.com Gerrit-MessageType: comment

Jeremy Soller (Code Review)

21 Jul 21 Jul

12:02 a.m.

Hello build bot (Jenkins), Angel Pons,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/43623

to look at the new patch set (#7).

Change subject: mb/system76/lemp9: enable I2C HID touchpad ......................................................................

mb/system76/lemp9: enable I2C HID touchpad

Tested on lemp9, touchpad confirmed to use i2c-hid driver in Linux instead of PS/2.

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/23/43623/7

Jeremy Soller (Code Review)

12:11 a.m.

Hello build bot (Jenkins), Angel Pons,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/43623

to look at the new patch set (#8).

Change subject: mb/system76/lemp9: enable I2C HID touchpad ......................................................................

mb/system76/lemp9: enable I2C HID touchpad

Tested on lemp9, touchpad confirmed to use i2c-hid driver in Linux instead of PS/2.

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/23/43623/8

Angel Pons (Code Review)

12:22 a.m.

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43623 )

Change subject: mb/system76/lemp9: enable I2C HID touchpad ......................................................................

Patch Set 8:

(1 comment)

https://review.coreboot.org/c/coreboot/+/43623/8/src/mainboard/system76/lemp... File src/mainboard/system76/lemp9/gpio.h:

https://review.coreboot.org/c/coreboot/+/43623/8/src/mainboard/system76/lemp... PS8, Line 143: PAD_CFG_GPI_APIC(GPP_B3, NONE, PLTRST, EDGE_SINGLE, INVERT), Isn't this the same as `PAD_CFG_GPI_APIC_EDGE_LOW(GPP_B3, NONE, PLTRST)` ?

-- To view, visit https://review.coreboot.org/c/coreboot/+/43623 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic3a90fda134b1d53f28ab687b3033ec52fee843b Gerrit-Change-Number: 43623 Gerrit-PatchSet: 8 Gerrit-Owner: Jeremy Soller jeremy@system76.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Mon, 20 Jul 2020 22:22:56 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Jeremy Soller (Code Review)

12:25 a.m.

Hello build bot (Jenkins), Angel Pons,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/43623

to look at the new patch set (#9).

Change subject: mb/system76/lemp9: enable I2C HID touchpad ......................................................................

mb/system76/lemp9: enable I2C HID touchpad

Tested on lemp9, touchpad confirmed to use i2c-hid driver in Linux instead of PS/2.

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/23/43623/9

Angel Pons (Code Review)

12:33 a.m.

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43623 )

Change subject: mb/system76/lemp9: enable I2C HID touchpad ......................................................................

Patch Set 9:

(1 comment)

https://review.coreboot.org/c/coreboot/+/43623/9/src/mainboard/system76/lemp... File src/mainboard/system76/lemp9/devicetree.cb:

https://review.coreboot.org/c/coreboot/+/43623/9/src/mainboard/system76/lemp... PS9, Line 56: PchSerialIoPci Since coreboot already initializes the UART, this should be:

PchSerialIoSkipInit

-- To view, visit https://review.coreboot.org/c/coreboot/+/43623 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic3a90fda134b1d53f28ab687b3033ec52fee843b Gerrit-Change-Number: 43623 Gerrit-PatchSet: 9 Gerrit-Owner: Jeremy Soller jeremy@system76.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Mon, 20 Jul 2020 22:33:53 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Michael Niewöhner (Code Review)

12:45 a.m.

Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43623 )

Change subject: mb/system76/lemp9: enable I2C HID touchpad ......................................................................

Patch Set 9:

(1 comment)

https://review.coreboot.org/c/coreboot/+/43623/9/src/mainboard/system76/lemp... File src/mainboard/system76/lemp9/devicetree.cb:

https://review.coreboot.org/c/coreboot/+/43623/9/src/mainboard/system76/lemp... PS9, Line 46: [PchSerialIoIndexI2C1] = PchSerialIoDisabled, : [PchSerialIoIndexI2C2] = PchSerialIoDisabled, : [PchSerialIoIndexI2C3] = PchSerialIoDisabled, : [PchSerialIoIndexI2C4] = PchSerialIoDisabled, : [PchSerialIoIndexI2C5] = PchSerialIoDisabled, : [PchSerialIoIndexSPI0] = PchSerialIoDisabled, : [PchSerialIoIndexSPI1] = PchSerialIoDisabled, : [PchSerialIoIndexSPI2] = PchSerialIoDisabled, : [PchSerialIoIndexUART0] = PchSerialIoDisabled, : [PchSerialIoIndexUART1] = PchSerialIoDisabled, : wait... this commit should only add the touchpad, nothing more. see CB:43642 for the uart part

-- To view, visit https://review.coreboot.org/c/coreboot/+/43623 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic3a90fda134b1d53f28ab687b3033ec52fee843b Gerrit-Change-Number: 43623 Gerrit-PatchSet: 9 Gerrit-Owner: Jeremy Soller jeremy@system76.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Michael Niewöhner Gerrit-Comment-Date: Mon, 20 Jul 2020 22:45:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Michael Niewöhner (Code Review)

12:46 a.m.

Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43623 )

Change subject: mb/system76/lemp9: enable I2C HID touchpad ......................................................................

Patch Set 9:

(2 comments)

https://review.coreboot.org/c/coreboot/+/43623/9/src/mainboard/system76/lemp... File src/mainboard/system76/lemp9/devicetree.cb:

https://review.coreboot.org/c/coreboot/+/43623/9/src/mainboard/system76/lemp... PS9, Line 220: register "generic.hid" = ""PNP0C50"" no, this is the CID, HID should be ELAN040D

https://review.coreboot.org/c/coreboot/+/43623/9/src/mainboard/system76/lemp... PS9, Line 225: 15 hex 0x0f

-- To view, visit https://review.coreboot.org/c/coreboot/+/43623 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic3a90fda134b1d53f28ab687b3033ec52fee843b Gerrit-Change-Number: 43623 Gerrit-PatchSet: 9 Gerrit-Owner: Jeremy Soller jeremy@system76.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Michael Niewöhner Gerrit-Comment-Date: Mon, 20 Jul 2020 22:46:37 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Michael Niewöhner (Code Review)

12:47 a.m.

Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43623 )

Change subject: mb/system76/lemp9: enable I2C HID touchpad ......................................................................

Patch Set 9:

(2 comments)

https://review.coreboot.org/c/coreboot/+/43623/9/src/mainboard/system76/lemp... File src/mainboard/system76/lemp9/devicetree.cb:

https://review.coreboot.org/c/coreboot/+/43623/9/src/mainboard/system76/lemp... PS9, Line 2: # Lock Down move that to chipset_lockdown

https://review.coreboot.org/c/coreboot/+/43623/9/src/mainboard/system76/lemp... PS9, Line 5: .i2c[0] = { /* I2C Touchpad */

-- To view, visit https://review.coreboot.org/c/coreboot/+/43623 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic3a90fda134b1d53f28ab687b3033ec52fee843b Gerrit-Change-Number: 43623 Gerrit-PatchSet: 9 Gerrit-Owner: Jeremy Soller jeremy@system76.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Michael Niewöhner Gerrit-Comment-Date: Mon, 20 Jul 2020 22:47:27 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Angel Pons (Code Review)

1:26 a.m.

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43623 )

Change subject: mb/system76/lemp9: enable I2C HID touchpad ......................................................................

Patch Set 9:

(1 comment)

https://review.coreboot.org/c/coreboot/+/43623/9/src/mainboard/system76/lemp... File src/mainboard/system76/lemp9/devicetree.cb:

https://review.coreboot.org/c/coreboot/+/43623/9/src/mainboard/system76/lemp... PS9, Line 56: PchSerialIoPci

...

Since coreboot already initializes the UART, this should be: […]

Or we can get CB:43639 in first, your choice.

-- To view, visit https://review.coreboot.org/c/coreboot/+/43623 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic3a90fda134b1d53f28ab687b3033ec52fee843b Gerrit-Change-Number: 43623 Gerrit-PatchSet: 9 Gerrit-Owner: Jeremy Soller jeremy@system76.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Michael Niewöhner Gerrit-Comment-Date: Mon, 20 Jul 2020 23:26:34 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons th3fanbus@gmail.com Gerrit-MessageType: comment

Angel Pons (Code Review)

1:27 a.m.

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43623 )

Change subject: mb/system76/lemp9: enable I2C HID touchpad ......................................................................

Patch Set 9:

(1 comment)

https://review.coreboot.org/c/coreboot/+/43623/9/src/mainboard/system76/lemp... File src/mainboard/system76/lemp9/devicetree.cb:

...

wait... this commit should only add the touchpad, nothing more. […]

Did you mean CB:43639 ?

-- To view, visit https://review.coreboot.org/c/coreboot/+/43623 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic3a90fda134b1d53f28ab687b3033ec52fee843b Gerrit-Change-Number: 43623 Gerrit-PatchSet: 9 Gerrit-Owner: Jeremy Soller jeremy@system76.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Michael Niewöhner Gerrit-Comment-Date: Mon, 20 Jul 2020 23:27:33 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Michael Niewöhner Gerrit-MessageType: comment

Michael Niewöhner (Code Review)

2:15 a.m.

Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43623 )

Change subject: mb/system76/lemp9: enable I2C HID touchpad ......................................................................

Patch Set 9:

(1 comment)

https://review.coreboot.org/c/coreboot/+/43623/9/src/mainboard/system76/lemp... File src/mainboard/system76/lemp9/devicetree.cb:

...

Did you mean CB:43639 ?

Yes... thx

-- To view, visit https://review.coreboot.org/c/coreboot/+/43623 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic3a90fda134b1d53f28ab687b3033ec52fee843b Gerrit-Change-Number: 43623 Gerrit-PatchSet: 9 Gerrit-Owner: Jeremy Soller jeremy@system76.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Michael Niewöhner Gerrit-Comment-Date: Tue, 21 Jul 2020 00:15:14 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons th3fanbus@gmail.com Comment-In-Reply-To: Michael Niewöhner Gerrit-MessageType: comment

Michael Niewöhner (Code Review)

2:17 a.m.

Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43623 )

Change subject: mb/system76/lemp9: enable I2C HID touchpad ......................................................................

Patch Set 9:

(1 comment)

https://review.coreboot.org/c/coreboot/+/43623/9/src/mainboard/system76/lemp... File src/mainboard/system76/lemp9/devicetree.cb:

https://review.coreboot.org/c/coreboot/+/43623/9/src/mainboard/system76/lemp... PS9, Line 46: [PchSerialIoIndexI2C1] = PchSerialIoDisabled, : [PchSerialIoIndexI2C2] = PchSerialIoDisabled, : [PchSerialIoIndexI2C3] = PchSerialIoDisabled, : [PchSerialIoIndexI2C4] = PchSerialIoDisabled, : [PchSerialIoIndexI2C5] = PchSerialIoDisabled, : [PchSerialIoIndexSPI0] = PchSerialIoDisabled, : [PchSerialIoIndexSPI1] = PchSerialIoDisabled, : [PchSerialIoIndexSPI2] = PchSerialIoDisabled, : [PchSerialIoIndexUART0] = PchSerialIoDisabled, : [PchSerialIoIndexUART1] = PchSerialIoDisabled, : drop the disabled ones; disabled is default anyways

-- To view, visit https://review.coreboot.org/c/coreboot/+/43623 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic3a90fda134b1d53f28ab687b3033ec52fee843b Gerrit-Change-Number: 43623 Gerrit-PatchSet: 9 Gerrit-Owner: Jeremy Soller jeremy@system76.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Michael Niewöhner Gerrit-Comment-Date: Tue, 21 Jul 2020 00:17:29 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Michael Niewöhner (Code Review)

2:18 a.m.

Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43623 )

Change subject: mb/system76/lemp9: enable I2C HID touchpad ......................................................................

Patch Set 9:

(1 comment)

https://review.coreboot.org/c/coreboot/+/43623/9/src/mainboard/system76/lemp... File src/mainboard/system76/lemp9/devicetree.cb:

https://review.coreboot.org/c/coreboot/+/43623/9/src/mainboard/system76/lemp... PS9, Line 221: register "generic.desc" = ""ELAN Touchpad"" : register "generic.irq" = "ACPI_IRQ_EDGE_LOW(GPP_B3_IRQ)" : register "generic.probed" = "1" : register "hid_desc_reg_offset" = "0x01" : alignment

-- To view, visit https://review.coreboot.org/c/coreboot/+/43623 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic3a90fda134b1d53f28ab687b3033ec52fee843b Gerrit-Change-Number: 43623 Gerrit-PatchSet: 9 Gerrit-Owner: Jeremy Soller jeremy@system76.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Michael Niewöhner Gerrit-Comment-Date: Tue, 21 Jul 2020 00:18:33 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Jeremy Soller (Code Review)

2:46 a.m.

Jeremy Soller has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43623 )

Change subject: mb/system76/lemp9: enable I2C HID touchpad ......................................................................

Patch Set 9:

(4 comments)

https://review.coreboot.org/c/coreboot/+/43623/1//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/43623/1//COMMIT_MSG@9 PS1, Line 9: Tested on lemp9, touchpad confirmed to use I2C HID

...

"confirmed to use I2C HID"? What do you mean? […]

Done

https://review.coreboot.org/c/coreboot/+/43623/9/src/mainboard/system76/lemp... File src/mainboard/system76/lemp9/devicetree.cb:

https://review.coreboot.org/c/coreboot/+/43623/9/src/mainboard/system76/lemp... PS9, Line 2: # Lock Down

...

move that to chipset_lockdown

Think I'll remove the comment, it is pretty self-explanatory anyways

https://review.coreboot.org/c/coreboot/+/43623/9/src/mainboard/system76/lemp... PS9, Line 220: register "generic.hid" = ""PNP0C50""

...

no, this is the CID, HID should be ELAN040D

This is a generic touchpad, using this generic value for both CID and HID results in not requiring any drivers in Linux or Windows.

https://review.coreboot.org/c/coreboot/+/43623/9/src/mainboard/system76/lemp... PS9, Line 225: 15

...

hex 0x0f

This is 15 in hex, similar to the PCI devices. I would not change it

-- To view, visit https://review.coreboot.org/c/coreboot/+/43623 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic3a90fda134b1d53f28ab687b3033ec52fee843b Gerrit-Change-Number: 43623 Gerrit-PatchSet: 9 Gerrit-Owner: Jeremy Soller jeremy@system76.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Michael Niewöhner Gerrit-Comment-Date: Tue, 21 Jul 2020 00:46:15 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons th3fanbus@gmail.com Comment-In-Reply-To: Michael Niewöhner Gerrit-MessageType: comment

Jeremy Soller (Code Review)

2:47 a.m.

Hello build bot (Jenkins), Angel Pons,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/43623

to look at the new patch set (#10).

Change subject: mb/system76/lemp9: enable I2C HID touchpad ......................................................................

mb/system76/lemp9: enable I2C HID touchpad

Tested on lemp9, touchpad confirmed to use i2c-hid driver in Linux instead of PS/2.

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/23/43623/10

Paul Menzel (Code Review)

7:56 a.m.

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43623 )

Change subject: mb/system76/lemp9: enable I2C HID touchpad ......................................................................

Patch Set 11:

(1 comment)

https://review.coreboot.org/c/coreboot/+/43623/11//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/43623/11//COMMIT_MSG@8 PS11, Line 8: It’d be great, if you added

...

Enable the I2C HID driver, configure I2C port 0 and add the touchpad device to the devicetree.

from Michael’s commit message I3bd28846bb9cbb5f5b137c85eb6ccf77e47a923d [1].

[1]: https://review.coreboot.org/c/coreboot/+/43640/1

-- To view, visit https://review.coreboot.org/c/coreboot/+/43623 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic3a90fda134b1d53f28ab687b3033ec52fee843b Gerrit-Change-Number: 43623 Gerrit-PatchSet: 11 Gerrit-Owner: Jeremy Soller jeremy@system76.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Michael Niewöhner Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Tue, 21 Jul 2020 05:56:06 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Michael Niewöhner (Code Review)

12:14 p.m.

Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43623 )

Change subject: mb/system76/lemp9: enable I2C HID touchpad ......................................................................

Patch Set 11:

(1 comment)

https://review.coreboot.org/c/coreboot/+/43623/11//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/43623/11//COMMIT_MSG@8 PS11, Line 8:

...

It’d be great, if you added […]

you mean CB:43653 ;)

-- To view, visit https://review.coreboot.org/c/coreboot/+/43623 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic3a90fda134b1d53f28ab687b3033ec52fee843b Gerrit-Change-Number: 43623 Gerrit-PatchSet: 11 Gerrit-Owner: Jeremy Soller jeremy@system76.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Michael Niewöhner Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Tue, 21 Jul 2020 10:14:29 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: comment

Jeremy Soller (Code Review)

4:20 p.m.

Hello build bot (Jenkins), Angel Pons,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/43623

to look at the new patch set (#12).

Change subject: mb/system76/lemp9: enable I2C HID touchpad ......................................................................

mb/system76/lemp9: enable I2C HID touchpad

Enable the I2C HID driver, configure I2C bus 0 and add the touchpad device to the devicetree.

Tested on lemp9, touchpad confirmed to use i2c-hid driver in Linux instead of PS/2.

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/23/43623/12

-- To view, visit https://review.coreboot.org/c/coreboot/+/43623 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic3a90fda134b1d53f28ab687b3033ec52fee843b Gerrit-Change-Number: 43623 Gerrit-PatchSet: 12 Gerrit-Owner: Jeremy Soller jeremy@system76.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Michael Niewöhner Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: newpatchset

Michael Niewöhner (Code Review)

4:36 p.m.

Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43623 )

Change subject: mb/system76/lemp9: enable I2C HID touchpad ......................................................................

Patch Set 13:

(5 comments)

https://review.coreboot.org/c/coreboot/+/43623/9/src/mainboard/system76/lemp... File src/mainboard/system76/lemp9/devicetree.cb:

https://review.coreboot.org/c/coreboot/+/43623/9/src/mainboard/system76/lemp... PS9, Line 2: # Lock Down

...

Think I'll remove the comment, it is pretty self-explanatory anyways

Ack

https://review.coreboot.org/c/coreboot/+/43623/9/src/mainboard/system76/lemp... PS9, Line 5: .i2c[0] = {

...

/* I2C Touchpad */

Done

...

drop the disabled ones; disabled is default anyways

Done

https://review.coreboot.org/c/coreboot/+/43623/9/src/mainboard/system76/lemp... PS9, Line 225: 15

...

This is 15 in hex, similar to the PCI devices. […]

Ack

https://review.coreboot.org/c/coreboot/+/43623/13/src/mainboard/system76/lem... File src/mainboard/system76/lemp9/devicetree.cb:

https://review.coreboot.org/c/coreboot/+/43623/13/src/mainboard/system76/lem... PS13, Line 46: [PchSerialIoIndexUART2] = PchSerialIoSkipInit, // LPSS UART this is not explained and also still has nothing to do with the touchpad -> separate commit

-- To view, visit https://review.coreboot.org/c/coreboot/+/43623 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic3a90fda134b1d53f28ab687b3033ec52fee843b Gerrit-Change-Number: 43623 Gerrit-PatchSet: 13 Gerrit-Owner: Jeremy Soller jeremy@system76.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Michael Niewöhner Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Tue, 21 Jul 2020 14:36:55 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Jeremy Soller jeremy@system76.com Comment-In-Reply-To: Michael Niewöhner Gerrit-MessageType: comment

Michael Niewöhner (Code Review)

5:09 p.m.

Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43623 )

Change subject: mb/system76/lemp9: enable I2C HID touchpad ......................................................................

Patch Set 13:

(1 comment)

https://review.coreboot.org/c/coreboot/+/43623/9/src/mainboard/system76/lemp... File src/mainboard/system76/lemp9/devicetree.cb:

https://review.coreboot.org/c/coreboot/+/43623/9/src/mainboard/system76/lemp... PS9, Line 220: register "generic.hid" = ""PNP0C50""

...

This is a generic touchpad, using this generic value for both CID and HID results in not requiring a […]

Did you test ELAN040D as hid? I'm ok with that if it doesn't

-- To view, visit https://review.coreboot.org/c/coreboot/+/43623 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic3a90fda134b1d53f28ab687b3033ec52fee843b Gerrit-Change-Number: 43623 Gerrit-PatchSet: 13 Gerrit-Owner: Jeremy Soller jeremy@system76.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Michael Niewöhner Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Tue, 21 Jul 2020 15:09:25 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Jeremy Soller jeremy@system76.com Comment-In-Reply-To: Michael Niewöhner Gerrit-MessageType: comment

Jeremy Soller (Code Review)

5:21 p.m.

Jeremy Soller has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43623 )

Change subject: mb/system76/lemp9: enable I2C HID touchpad ......................................................................

Patch Set 13:

(2 comments)

https://review.coreboot.org/c/coreboot/+/43623/9/src/mainboard/system76/lemp... File src/mainboard/system76/lemp9/devicetree.cb:

https://review.coreboot.org/c/coreboot/+/43623/9/src/mainboard/system76/lemp... PS9, Line 220: register "generic.hid" = ""PNP0C50""

...

Did you test ELAN040D as hid? I'm ok with that if it doesn't

I will try that value, I guess it doesn't hurt to be more specific, if the generic drivers still work

https://review.coreboot.org/c/coreboot/+/43623/13/src/mainboard/system76/lem... File src/mainboard/system76/lemp9/devicetree.cb:

https://review.coreboot.org/c/coreboot/+/43623/13/src/mainboard/system76/lem... PS13, Line 46: [PchSerialIoIndexUART2] = PchSerialIoSkipInit, // LPSS UART

...

this is not explained and also still has nothing to do with the touchpad -> separate commit

Good point, will add a new commit doing this

-- To view, visit https://review.coreboot.org/c/coreboot/+/43623 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic3a90fda134b1d53f28ab687b3033ec52fee843b Gerrit-Change-Number: 43623 Gerrit-PatchSet: 13 Gerrit-Owner: Jeremy Soller jeremy@system76.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Michael Niewöhner Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Tue, 21 Jul 2020 15:21:17 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Jeremy Soller jeremy@system76.com Comment-In-Reply-To: Michael Niewöhner Gerrit-MessageType: comment

Michael Niewöhner (Code Review)

5:23 p.m.

Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43623 )

Change subject: mb/system76/lemp9: enable I2C HID touchpad ......................................................................

Patch Set 13:

(1 comment)

https://review.coreboot.org/c/coreboot/+/43623/9/src/mainboard/system76/lemp... File src/mainboard/system76/lemp9/devicetree.cb:

https://review.coreboot.org/c/coreboot/+/43623/9/src/mainboard/system76/lemp... PS9, Line 220: register "generic.hid" = ""PNP0C50""

...

Did you test ELAN040D as hid? I'm ok with that if it doesn't

Hmm, to me this reads differently here... CID is the compatible id which is checked if a driver for HID was not found. If a driver exists, the OS should use that one instead of a generic one. https://docs.microsoft.com/en-us/windows-hardware/drivers/bringup/device-man...

Same applies to Linux AFAICT

-- To view, visit https://review.coreboot.org/c/coreboot/+/43623 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic3a90fda134b1d53f28ab687b3033ec52fee843b Gerrit-Change-Number: 43623 Gerrit-PatchSet: 13 Gerrit-Owner: Jeremy Soller jeremy@system76.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Michael Niewöhner Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Tue, 21 Jul 2020 15:23:11 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Jeremy Soller jeremy@system76.com Comment-In-Reply-To: Michael Niewöhner Gerrit-MessageType: comment

Jeremy Soller (Code Review)

5:24 p.m.

Hello build bot (Jenkins), Angel Pons,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/43623

to look at the new patch set (#14).

Change subject: mb/system76/lemp9: enable I2C HID touchpad ......................................................................

mb/system76/lemp9: enable I2C HID touchpad

Enable the I2C HID driver, configure I2C bus 0 and add the touchpad device to the devicetree.

Tested on lemp9, touchpad confirmed to use i2c-hid driver in Linux instead of PS/2.

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/23/43623/14

-- To view, visit https://review.coreboot.org/c/coreboot/+/43623 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic3a90fda134b1d53f28ab687b3033ec52fee843b Gerrit-Change-Number: 43623 Gerrit-PatchSet: 14 Gerrit-Owner: Jeremy Soller jeremy@system76.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Michael Niewöhner Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: newpatchset

Jeremy Soller (Code Review)

5:25 p.m.

Hello build bot (Jenkins), Angel Pons,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/43623

to look at the new patch set (#15).

Change subject: mb/system76/lemp9: enable I2C HID touchpad ......................................................................

mb/system76/lemp9: enable I2C HID touchpad

Enable the I2C HID driver, configure I2C bus 0 and add the touchpad device to the devicetree.

Tested on lemp9, touchpad confirmed to use i2c-hid driver in Linux instead of PS/2.

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/23/43623/15

-- To view, visit https://review.coreboot.org/c/coreboot/+/43623 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic3a90fda134b1d53f28ab687b3033ec52fee843b Gerrit-Change-Number: 43623 Gerrit-PatchSet: 15 Gerrit-Owner: Jeremy Soller jeremy@system76.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Michael Niewöhner Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: newpatchset

Michael Niewöhner (Code Review)

9:27 p.m.

Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43623 )

Change subject: mb/system76/lemp9: enable I2C HID touchpad ......................................................................

Patch Set 15:

(1 comment)

https://review.coreboot.org/c/coreboot/+/43623/13/src/mainboard/system76/lem... File src/mainboard/system76/lemp9/devicetree.cb:

https://review.coreboot.org/c/coreboot/+/43623/13/src/mainboard/system76/lem... PS13, Line 46: [PchSerialIoIndexUART2] = PchSerialIoSkipInit, // LPSS UART

...

Good point, will add a new commit doing this

Done

-- To view, visit https://review.coreboot.org/c/coreboot/+/43623 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic3a90fda134b1d53f28ab687b3033ec52fee843b Gerrit-Change-Number: 43623 Gerrit-PatchSet: 15 Gerrit-Owner: Jeremy Soller jeremy@system76.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Michael Niewöhner Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Tue, 21 Jul 2020 19:27:32 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Jeremy Soller jeremy@system76.com Comment-In-Reply-To: Michael Niewöhner Gerrit-MessageType: comment

Jeremy Soller (Code Review)

22 Jul 22 Jul

2:45 p.m.

Hello build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/43623

to look at the new patch set (#16).

Change subject: mb/system76/lemp9: enable I2C HID touchpad ......................................................................

mb/system76/lemp9: enable I2C HID touchpad

Enable the I2C HID driver, configure I2C bus 0 and add the touchpad device to the devicetree.

Tested on lemp9, touchpad confirmed to use i2c-hid driver in Linux instead of PS/2.

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/23/43623/16

Jeremy Soller (Code Review)

4:09 p.m.

Hello build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/43623

to look at the new patch set (#18).

Change subject: mb/system76/lemp9: enable I2C HID touchpad ......................................................................

mb/system76/lemp9: enable I2C HID touchpad

Enable the I2C HID driver, configure I2C bus 0 and add the touchpad device to the devicetree.

Tested on lemp9, touchpad confirmed to use i2c-hid driver in Linux instead of PS/2.

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/23/43623/18

Michael Niewöhner (Code Review)

24 Jul 24 Jul

6:57 p.m.

Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43623 )

Change subject: mb/system76/lemp9: enable I2C HID touchpad ......................................................................

Patch Set 19: Code-Review+1

(4 comments)

https://review.coreboot.org/c/coreboot/+/43623/9/src/mainboard/system76/lemp... File src/mainboard/system76/lemp9/devicetree.cb:

https://review.coreboot.org/c/coreboot/+/43623/9/src/mainboard/system76/lemp... PS9, Line 56: PchSerialIoPci

...

Or we can get CB:43639 in first, your choice.

Done

...

Yes... […]

Done

https://review.coreboot.org/c/coreboot/+/43623/9/src/mainboard/system76/lemp... PS9, Line 220: register "generic.hid" = ""PNP0C50""

...

Hmm, to me this reads differently here... […]

Done

https://review.coreboot.org/c/coreboot/+/43623/19/src/mainboard/system76/lem... File src/mainboard/system76/lemp9/devicetree.cb:

https://review.coreboot.org/c/coreboot/+/43623/19/src/mainboard/system76/lem... PS19, Line 207: on keep the comment here, to keep it in line with the others

-- To view, visit https://review.coreboot.org/c/coreboot/+/43623 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic3a90fda134b1d53f28ab687b3033ec52fee843b Gerrit-Change-Number: 43623 Gerrit-PatchSet: 19 Gerrit-Owner: Jeremy Soller jeremy@system76.com Gerrit-Reviewer: Michael Niewöhner Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Fri, 24 Jul 2020 16:57:07 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Jeremy Soller jeremy@system76.com Comment-In-Reply-To: Angel Pons th3fanbus@gmail.com Comment-In-Reply-To: Michael Niewöhner Gerrit-MessageType: comment

Michael Niewöhner (Code Review)

25 Jul 25 Jul

1:22 a.m.

Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43623 )

Change subject: mb/system76/lemp9: enable I2C HID touchpad ......................................................................

Patch Set 19:

(1 comment)

https://review.coreboot.org/c/coreboot/+/43623/8/src/mainboard/system76/lemp... File src/mainboard/system76/lemp9/gpio.h:

https://review.coreboot.org/c/coreboot/+/43623/8/src/mainboard/system76/lemp... PS8, Line 143: PAD_CFG_GPI_APIC(GPP_B3, NONE, PLTRST, EDGE_SINGLE, INVERT),

...

Isn't this the same as `PAD_CFG_GPI_APIC_EDGE_LOW(GPP_B3, NONE, PLTRST)` ?

yes, it is...

-- To view, visit https://review.coreboot.org/c/coreboot/+/43623 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic3a90fda134b1d53f28ab687b3033ec52fee843b Gerrit-Change-Number: 43623 Gerrit-PatchSet: 19 Gerrit-Owner: Jeremy Soller jeremy@system76.com Gerrit-Reviewer: Michael Niewöhner Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Fri, 24 Jul 2020 23:22:32 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons th3fanbus@gmail.com Gerrit-MessageType: comment

Michael Niewöhner (Code Review)

1:23 a.m.

Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43623 )

Change subject: mb/system76/lemp9: enable I2C HID touchpad ......................................................................

Patch Set 19:

(1 comment)

https://review.coreboot.org/c/coreboot/+/43623/8/src/mainboard/system76/lemp... File src/mainboard/system76/lemp9/gpio.h:

https://review.coreboot.org/c/coreboot/+/43623/8/src/mainboard/system76/lemp... PS8, Line 143: PAD_CFG_GPI_APIC(GPP_B3, NONE, PLTRST, EDGE_SINGLE, INVERT),

...

yes, it is...

Done

-- To view, visit https://review.coreboot.org/c/coreboot/+/43623 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic3a90fda134b1d53f28ab687b3033ec52fee843b Gerrit-Change-Number: 43623 Gerrit-PatchSet: 19 Gerrit-Owner: Jeremy Soller jeremy@system76.com Gerrit-Reviewer: Michael Niewöhner Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Fri, 24 Jul 2020 23:23:51 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons th3fanbus@gmail.com Comment-In-Reply-To: Michael Niewöhner Gerrit-MessageType: comment

Michael Niewöhner (Code Review)

30 Aug 30 Aug

3:20 p.m.

Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43623 )

Change subject: mb/system76/lemp9: enable I2C HID touchpad ......................................................................

Patch Set 19: Code-Review+2

tested; works fine for me, too

-- To view, visit https://review.coreboot.org/c/coreboot/+/43623 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic3a90fda134b1d53f28ab687b3033ec52fee843b Gerrit-Change-Number: 43623 Gerrit-PatchSet: 19 Gerrit-Owner: Jeremy Soller jeremy@system76.com Gerrit-Reviewer: Michael Niewöhner Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Sun, 30 Aug 2020 13:20:24 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Michael Niewöhner (Code Review)

6 Sep 6 Sep

5:14 p.m.

Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43623 )

Change subject: mb/system76/lemp9: enable I2C HID touchpad ......................................................................

Patch Set 19:

(2 comments)

https://review.coreboot.org/c/coreboot/+/43623/4//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/43623/4//COMMIT_MSG@10 PS4, Line 10: ps/2

...

nit: PS/2

Done

https://review.coreboot.org/c/coreboot/+/43623/11//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/43623/11//COMMIT_MSG@8 PS11, Line 8:

...

you mean CB:43653 ;)

Done

-- To view, visit https://review.coreboot.org/c/coreboot/+/43623 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic3a90fda134b1d53f28ab687b3033ec52fee843b Gerrit-Change-Number: 43623 Gerrit-PatchSet: 19 Gerrit-Owner: Jeremy Soller jeremy@system76.com Gerrit-Reviewer: Michael Niewöhner Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Sun, 06 Sep 2020 15:14:26 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel paulepanter@users.sourceforge.net Comment-In-Reply-To: Angel Pons th3fanbus@gmail.com Comment-In-Reply-To: Michael Niewöhner Gerrit-MessageType: comment

Michael Niewöhner (Code Review)

6:36 p.m.

Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43623 )

Change subject: mb/system76/lemp9: enable I2C HID touchpad ......................................................................

Patch Set 19:

(2 comments)

https://review.coreboot.org/c/coreboot/+/43623/9/src/mainboard/system76/lemp... File src/mainboard/system76/lemp9/devicetree.cb:

...

alignment

let's get this in; a global style fix is required anyways

https://review.coreboot.org/c/coreboot/+/43623/19/src/mainboard/system76/lem... File src/mainboard/system76/lemp9/devicetree.cb:

https://review.coreboot.org/c/coreboot/+/43623/19/src/mainboard/system76/lem... PS19, Line 207: on

...

keep the comment here, to keep it in line with the others

let's get this in; a global style fix is required anyways

-- To view, visit https://review.coreboot.org/c/coreboot/+/43623 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic3a90fda134b1d53f28ab687b3033ec52fee843b Gerrit-Change-Number: 43623 Gerrit-PatchSet: 19 Gerrit-Owner: Jeremy Soller jeremy@system76.com Gerrit-Reviewer: Michael Niewöhner Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Sun, 06 Sep 2020 16:36:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Michael Niewöhner Gerrit-MessageType: comment

Michael Niewöhner (Code Review)

6:37 p.m.

Michael Niewöhner has submitted this change. ( https://review.coreboot.org/c/coreboot/+/43623 )

Change subject: mb/system76/lemp9: enable I2C HID touchpad ......................................................................

mb/system76/lemp9: enable I2C HID touchpad

Enable the I2C HID driver, configure I2C bus 0 and add the touchpad device to the devicetree.

Tested on lemp9, touchpad confirmed to use i2c-hid driver in Linux instead of PS/2.

Signed-off-by: Jeremy Soller jeremy@system76.com Change-Id: Ic3a90fda134b1d53f28ab687b3033ec52fee843b Reviewed-on: https://review.coreboot.org/c/coreboot/+/43623 Reviewed-by: Michael Niewöhner Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/system76/lemp9/Kconfig M src/mainboard/system76/lemp9/devicetree.cb M src/mainboard/system76/lemp9/gpio.h 3 files changed, 24 insertions(+), 4 deletions(-)

Approvals: build bot (Jenkins): Verified Michael Niewöhner: Looks good to me, approved

diff --git a/src/mainboard/system76/lemp9/Kconfig b/src/mainboard/system76/lemp9/Kconfig index 6f2bee7..6b5b750 100644 --- a/src/mainboard/system76/lemp9/Kconfig +++ b/src/mainboard/system76/lemp9/Kconfig @@ -3,6 +3,7 @@ config BOARD_SPECIFIC_OPTIONS def_bool y select BOARD_ROMSIZE_KB_16384 + select DRIVERS_I2C_HID select EC_SYSTEM76_EC select HAVE_ACPI_RESUME select HAVE_ACPI_TABLES diff --git a/src/mainboard/system76/lemp9/devicetree.cb b/src/mainboard/system76/lemp9/devicetree.cb index e0da72a..6adc188 100644 --- a/src/mainboard/system76/lemp9/devicetree.cb +++ b/src/mainboard/system76/lemp9/devicetree.cb @@ -1,7 +1,12 @@ chip soc/intel/cannonlake - # Lock Down register "common_soc_config" = "{ .chipset_lockdown = CHIPSET_LOCKDOWN_COREBOOT, + /* Touchpad */ + .i2c[0] = { + .speed = I2C_SPEED_FAST, + .rise_time_ns = 80, + .fall_time_ns = 110, + }, }"

# Send an extra VR mailbox command for the PS4 exit issue @@ -35,6 +40,11 @@ #register "enable_c6dram" = "1"

# FSP Silicon (soc/intel/cannonlake/fsp_params.c) + # Serial I/O + register "SerialIoDevMode" = "{ + [PchSerialIoIndexI2C0] = PchSerialIoPci, // Touchpad + }" + # SATA register "SataMode" = "Sata_AHCI" register "SataSalpSupport" = "0" @@ -185,7 +195,16 @@ device pci 14.3 on end end device pci 14.5 off end # SDCard - device pci 15.0 off end # I2C #0 + device pci 15.0 on + chip drivers/i2c/hid + register "generic.hid" = ""ELAN040D"" + register "generic.desc" = ""ELAN Touchpad"" + register "generic.irq" = "ACPI_IRQ_EDGE_LOW(GPP_B3_IRQ)" + register "generic.probed" = "1" + register "hid_desc_reg_offset" = "0x01" + device i2c 15 on end + end + end # I2C #0 device pci 15.1 off end # I2C #1 device pci 15.2 off end # I2C #2 device pci 15.3 off end # I2C #3 diff --git a/src/mainboard/system76/lemp9/gpio.h b/src/mainboard/system76/lemp9/gpio.h index 9c99f13..3373c6c 100644 --- a/src/mainboard/system76/lemp9/gpio.h +++ b/src/mainboard/system76/lemp9/gpio.h @@ -138,8 +138,8 @@ PAD_NC(GPP_B2, UP_20K),

// CPU Misc - // GPP_B3 - _PAD_CFG_STRUCT(GPP_B3, 0x80100100, 0x0000), + // GPP_B3 (touchpad interrupt) + PAD_CFG_GPI_APIC_EDGE_LOW(GPP_B3, NONE, PLTRST), // NC PAD_NC(GPP_B4, UP_20K),

1539

days inactive

1587

days old

coreboot-gerrit@coreboot.org

38 comments

4 participants

tags (0)

participants (4)

Angel Pons (Code Review)
Jeremy Soller (Code Review)
Michael Niewöhner (Code Review)
Paul Menzel (Code Review)