Change in coreboot[master]: mb/asus/p8h61-m_pro: Disable SVID LDN

List overview All Threads
Download

newer

older

Change in coreboot[master]: acpi:...

Angel Pons (Code Review)

27 Apr 2020 27 Apr '20

12:21 a.m.

Angel Pons has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/40739 )

Change subject: mb/asus/p8h61-m_pro: Disable SVID LDN ......................................................................

mb/asus/p8h61-m_pro: Disable SVID LDN

The SVID functionality is not used on this mainboard. Turn it off.

Change-Id: Iea891975b32d24f54edec9d8c36391ec60a37d0c Signed-off-by: Angel Pons th3fanbus@gmail.com --- M src/mainboard/asus/p8h61-m_pro/devicetree.cb 1 file changed, 1 insertion(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/39/40739/1

diff --git a/src/mainboard/asus/p8h61-m_pro/devicetree.cb b/src/mainboard/asus/p8h61-m_pro/devicetree.cb index 2d1550d..71f2b41 100644 --- a/src/mainboard/asus/p8h61-m_pro/devicetree.cb +++ b/src/mainboard/asus/p8h61-m_pro/devicetree.cb @@ -102,7 +102,7 @@ device pnp 2e.f on # GPIO Push-Pull or Open-drain irq 0xf0 = 0x9d end - device pnp 2e.14 on end # SVID + device pnp 2e.14 off end # SVID device pnp 2e.16 on # Deep Sleep io 0x30 = 0x20 end

Attachments:

attachment.htm (text/html — 2.5 KB)

Show replies by date

Paul Menzel (Code Review)

27 Apr 27 Apr

12:27 a.m.

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40739 )

Change subject: mb/asus/p8h61-m_pro: Disable SVID LDN ......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/c/coreboot/+/40739/1//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/40739/1//COMMIT_MSG@10 PS1, Line 10: Does the vendor firmware do the same?

-- To view, visit https://review.coreboot.org/c/coreboot/+/40739 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iea891975b32d24f54edec9d8c36391ec60a37d0c Gerrit-Change-Number: 40739 Gerrit-PatchSet: 1 Gerrit-Owner: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Felix Singer felixsinger@posteo.net Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Sun, 26 Apr 2020 22:27:03 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Angel Pons (Code Review)

29 Apr 29 Apr

10:17 p.m.

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40739 )

Change subject: mb/asus/p8h61-m_pro: Disable SVID LDN ......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/c/coreboot/+/40739/1//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/40739/1//COMMIT_MSG@10 PS1, Line 10:

...

Does the vendor firmware do the same?

Yes.

-- To view, visit https://review.coreboot.org/c/coreboot/+/40739 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iea891975b32d24f54edec9d8c36391ec60a37d0c Gerrit-Change-Number: 40739 Gerrit-PatchSet: 1 Gerrit-Owner: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Felix Singer felixsinger@posteo.net Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Wed, 29 Apr 2020 20:17:15 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: comment

Felix Held (Code Review)

2 May 2 May

8:54 p.m.

Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40739 )

Change subject: mb/asus/p8h61-m_pro: Disable SVID LDN ......................................................................

Patch Set 1: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/40739 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iea891975b32d24f54edec9d8c36391ec60a37d0c Gerrit-Change-Number: 40739 Gerrit-PatchSet: 1 Gerrit-Owner: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Felix Singer felixsinger@posteo.net Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Sat, 02 May 2020 18:54:56 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Felix Held (Code Review)

8:58 p.m.

Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/40739 )

Change subject: mb/asus/p8h61-m_pro: Disable SVID LDN ......................................................................

mb/asus/p8h61-m_pro: Disable SVID LDN

The SVID functionality is not used on this mainboard. Turn it off.

Change-Id: Iea891975b32d24f54edec9d8c36391ec60a37d0c Signed-off-by: Angel Pons th3fanbus@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/40739 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Felix Held felix-coreboot@felixheld.de --- M src/mainboard/asus/p8h61-m_pro/devicetree.cb 1 file changed, 1 insertion(+), 1 deletion(-)

Approvals: build bot (Jenkins): Verified Felix Held: Looks good to me, approved

-- To view, visit https://review.coreboot.org/c/coreboot/+/40739 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iea891975b32d24f54edec9d8c36391ec60a37d0c Gerrit-Change-Number: 40739 Gerrit-PatchSet: 2 Gerrit-Owner: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Felix Singer felixsinger@posteo.net Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: merged

9elements QA (Code Review)

9:41 p.m.

9elements QA has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40739 )

Change subject: mb/asus/p8h61-m_pro: Disable SVID LDN ......................................................................

Patch Set 2:

Automatic boot test returned (PASS/FAIL/TOTAL): 4/0/4 Emulation targets: "QEMU x86 q35/ich9" using payload TianoCore : SUCCESS : https://lava.9esec.io/r/3139 "QEMU x86 q35/ich9" using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/3138 "QEMU x86 i440fx/piix4" using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/3137 "QEMU AArch64" using payload LinuxBoot_u-root_kexec : SUCCESS : https://lava.9esec.io/r/3136

Please note: This test is under development and might not be accurate at all!

-- To view, visit https://review.coreboot.org/c/coreboot/+/40739 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iea891975b32d24f54edec9d8c36391ec60a37d0c Gerrit-Change-Number: 40739 Gerrit-PatchSet: 2 Gerrit-Owner: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Felix Singer felixsinger@posteo.net Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: 9elements QA hardwaretestrobot@gmail.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Sat, 02 May 2020 19:41:29 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1666

days inactive

1672

days old

coreboot-gerrit@coreboot.org

5 comments

4 participants

tags (0)

participants (4)

9elements QA (Code Review)
Angel Pons (Code Review)
Felix Held (Code Review)
Paul Menzel (Code Review)