Attention is currently required from: Arthur Heymans, Christian Walter, Jincheng Li, Johnny Lin, Jonathan Zhang, Lean Sheng Tan, Shuo Liu, Tim Chu.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81219?usp=email )
The change is no longer submittable: All-Comments-Resolved is unsatisfied now.
Change subject: soc/intel/xeon_sp: Share DDR codes acorss Xeon-SP platforms
......................................................................
Patch Set 12: Code-Review+1
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/81219/comment/8828818e_ce2712e5 :
PS12, Line 7: acorss
ac*ro*ss
File src/soc/intel/xeon_sp/ddr.c:
https://review.coreboot.org/c/coreboot/+/81219/comment/8f23f83c_9fb49186 :
PS12, Line 5: uint32_t get_ddr_voltage(uint8_t DdrVoltage)
Not as part of this change, because you just moved it around. But would
be nice to align with coreboot coding style.
https://review.coreboot.org/c/coreboot/+/81219/comment/246be347_e90600a4 :
PS12, Line 107: }
Also just moved around. But why is this a function? Such information belongs
into the devicetree.
Also, do we expect gaps or different amount of slots per channel? otherwise,
this could just be a `slot <= CONFIG_DIMM_MAX`.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/81219?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I237d561003671d70dfaaa9823a0cf16d6e1f50cf
Gerrit-Change-Number: 81219
Gerrit-PatchSet: 12
Gerrit-Owner: Jincheng Li
jincheng.li@intel.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Reviewer: Jonathan Zhang
jon.zhixiong.zhang@gmail.com
Gerrit-Reviewer: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Shuo Liu
shuo.liu@intel.com
Gerrit-Reviewer: Tim Chu
Tim.Chu@quantatw.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Jonathan Zhang
jon.zhixiong.zhang@gmail.com
Gerrit-Attention: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Attention: Christian Walter
christian.walter@9elements.com
Gerrit-Attention: Shuo Liu
shuo.liu@intel.com
Gerrit-Attention: Jincheng Li
jincheng.li@intel.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Attention: Tim Chu
Tim.Chu@quantatw.com
Gerrit-Comment-Date: Fri, 22 Mar 2024 14:35:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment