Change in ...coreboot[master]: sb/intel/bd82x6x/lpc.c: Remove reinitializing the SPI driver

[Arthur Heymans (Code Review)]

Arthur Heymans has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/33390

Change subject: sb/intel/bd82x6x/lpc.c: Remove reinitializing the SPI driver
......................................................................

sb/intel/bd82x6x/lpc.c: Remove reinitializing the SPI driver

This was done to update the global variable g_ichspi_lock but this is
now removed in favor of reading the lock bit during runtime instead of
keeping track of the state.

Change-Id: I8cb69a152b0e050d64d8979ee92de2d24136f8dc
Signed-off-by: Arthur Heymans 
---
M src/southbridge/intel/bd82x6x/lpc.c
1 file changed, 0 insertions(+), 6 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/90/33390/1

diff --git a/src/southbridge/intel/bd82x6x/lpc.c b/src/southbridge/intel/bd82x6x/lpc.c
index 7737501..661c1d4 100644
--- a/src/southbridge/intel/bd82x6x/lpc.c
+++ b/src/southbridge/intel/bd82x6x/lpc.c
@@ -908,12 +908,6 @@
    	if (CONFIG(INTEL_CHIPSET_LOCKDOWN) ||
    	    acpi_is_wakeup_s3()) {
    		outb(APM_CNT_FINALIZE, APM_CNT);
-			if (CONFIG(CONSOLE_SPI_FLASH))
-				/* Re-init SPI driver to handle locked BAR.
-				   This prevents flashconsole from hanging.
-				   If other code needs to use SPI during
-				   ramstage, whitelist it here. */
-				spi_init();
    	}
    }
 }

[Nico Huber (Code Review)]

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33390 )

Change subject: sb/intel/bd82x6x/lpc.c: Remove reinitializing the SPI driver
......................................................................

Patch Set 4: Code-Review+2

+3

[Arthur Heymans (Code Review)]

Arthur Heymans has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/33390 )

Change subject: sb/intel/bd82x6x/lpc.c: Remove reinitializing the SPI driver
......................................................................

sb/intel/bd82x6x/lpc.c: Remove reinitializing the SPI driver

This was done to update the global variable g_ichspi_lock but this is
now removed in favor of reading the lock bit during runtime instead of
keeping track of the state.

Change-Id: I8cb69a152b0e050d64d8979ee92de2d24136f8dc
Signed-off-by: Arthur Heymans 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/33390
Reviewed-by: Nico Huber 
Tested-by: build bot (Jenkins) 
---
M src/southbridge/intel/bd82x6x/lpc.c
1 file changed, 0 insertions(+), 6 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Nico Huber: Looks good to me, approved

diff --git a/src/southbridge/intel/bd82x6x/lpc.c b/src/southbridge/intel/bd82x6x/lpc.c
index 7737501..661c1d4 100644
--- a/src/southbridge/intel/bd82x6x/lpc.c
+++ b/src/southbridge/intel/bd82x6x/lpc.c
@@ -908,12 +908,6 @@
    	if (CONFIG(INTEL_CHIPSET_LOCKDOWN) ||
    	    acpi_is_wakeup_s3()) {
    		outb(APM_CNT_FINALIZE, APM_CNT);
-			if (CONFIG(CONSOLE_SPI_FLASH))
-				/* Re-init SPI driver to handle locked BAR.
-				   This prevents flashconsole from hanging.
-				   If other code needs to use SPI during
-				   ramstage, whitelist it here. */
-				spi_init();
    	}
    }
 }