Attention is currently required from: Shelley Chen, Martin Roth, Julius Werner. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49767 )
Change subject: sc7280: aop blob loading changes ......................................................................
Patch Set 29:
(26 comments)
File src/soc/qualcomm/sc7280/aop_load_reset.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117207): https://review.coreboot.org/c/coreboot/+/49767/comment/b6963145_81c1035f PS29, Line 11: bool aop_fw_entry; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117207): https://review.coreboot.org/c/coreboot/+/49767/comment/e2525ff9_4cf404b4 PS29, Line 11: bool aop_fw_entry; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117207): https://review.coreboot.org/c/coreboot/+/49767/comment/6be38611_4d99f8d9 PS29, Line 13: struct prog aop_fw_prog = code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117207): https://review.coreboot.org/c/coreboot/+/49767/comment/21e3845f_d95483fb PS29, Line 13: struct prog aop_fw_prog = please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117207): https://review.coreboot.org/c/coreboot/+/49767/comment/8ca27e0c_6966779e PS29, Line 14: PROG_INIT(PROG_PAYLOAD, CONFIG_CBFS_PREFIX "/aop"); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117207): https://review.coreboot.org/c/coreboot/+/49767/comment/37c6c00a_d7ff42aa PS29, Line 14: PROG_INIT(PROG_PAYLOAD, CONFIG_CBFS_PREFIX "/aop"); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117207): https://review.coreboot.org/c/coreboot/+/49767/comment/ce3aff21_5b325b20 PS29, Line 16: if (prog_locate(&aop_fw_prog)) code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117207): https://review.coreboot.org/c/coreboot/+/49767/comment/5e3bb91d_edc557ae PS29, Line 16: if (prog_locate(&aop_fw_prog)) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117207): https://review.coreboot.org/c/coreboot/+/49767/comment/35c8bb7a_d95bd1b6 PS29, Line 17: die("SOC image: AOP_FW not found"); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117207): https://review.coreboot.org/c/coreboot/+/49767/comment/b8db5ee3_7be4df18 PS29, Line 17: die("SOC image: AOP_FW not found"); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117207): https://review.coreboot.org/c/coreboot/+/49767/comment/dff6d51c_8d635bb5 PS29, Line 19: aop_fw_entry = selfload(&aop_fw_prog); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117207): https://review.coreboot.org/c/coreboot/+/49767/comment/ce123248_6457e7f2 PS29, Line 19: aop_fw_entry = selfload(&aop_fw_prog); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117207): https://review.coreboot.org/c/coreboot/+/49767/comment/97c44a56_73df6320 PS29, Line 20: if (!aop_fw_entry) code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117207): https://review.coreboot.org/c/coreboot/+/49767/comment/898ee16a_fb6c78df PS29, Line 20: if (!aop_fw_entry) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117207): https://review.coreboot.org/c/coreboot/+/49767/comment/5bd19604_7c47b160 PS29, Line 21: die("SOC image: AOP load failed"); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117207): https://review.coreboot.org/c/coreboot/+/49767/comment/b4cca876_e7e1c3c8 PS29, Line 21: die("SOC image: AOP load failed"); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117207): https://review.coreboot.org/c/coreboot/+/49767/comment/939343af_d2ace470 PS29, Line 23: clock_reset_aop(); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117207): https://review.coreboot.org/c/coreboot/+/49767/comment/28e480ef_e3e7b173 PS29, Line 23: clock_reset_aop(); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117207): https://review.coreboot.org/c/coreboot/+/49767/comment/f481d934_42f3e184 PS29, Line 25: printk(BIOS_DEBUG, "\nSOC:AOP brought out of reset.\n"); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117207): https://review.coreboot.org/c/coreboot/+/49767/comment/e60e331a_ba02ca27 PS29, Line 25: printk(BIOS_DEBUG, "\nSOC:AOP brought out of reset.\n"); please, no spaces at the start of a line
File src/soc/qualcomm/sc7280/mmu.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117207): https://review.coreboot.org/c/coreboot/+/49767/comment/ae52ca2e_be30a19d PS29, Line 25: mmu_config_range((void *)_aop_code_ram, REGION_SIZE(aop_code_ram), CACHED_RAM); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117207): https://review.coreboot.org/c/coreboot/+/49767/comment/a2335f79_1626408e PS29, Line 25: mmu_config_range((void *)_aop_code_ram, REGION_SIZE(aop_code_ram), CACHED_RAM); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117207): https://review.coreboot.org/c/coreboot/+/49767/comment/8b8a6ae5_9505039f PS29, Line 26: mmu_config_range((void *)_aop_data_ram, REGION_SIZE(aop_data_ram), CACHED_RAM); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117207): https://review.coreboot.org/c/coreboot/+/49767/comment/28377d4e_0cbb5782 PS29, Line 26: mmu_config_range((void *)_aop_data_ram, REGION_SIZE(aop_data_ram), CACHED_RAM); please, no spaces at the start of a line
File src/soc/qualcomm/sc7280/soc.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117207): https://review.coreboot.org/c/coreboot/+/49767/comment/b0408629_6a462440 PS29, Line 15: REGION_SIZE(dram_aop) / KiB); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117207): https://review.coreboot.org/c/coreboot/+/49767/comment/3fa4c6c5_b50a0527 PS29, Line 15: REGION_SIZE(dram_aop) / KiB); please, no spaces at the start of a line
-
build bot (Jenkins) (Code Review)