Mario Scheithauer has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/46129 )
Change subject: mb/siemens/mc_bdx1: Fix IASL warning reported as error ......................................................................
mb/siemens/mc_bdx1: Fix IASL warning reported as error
Latest IASL version (20200717) leads to a build error on 4.11_branch.
dsdt.asl 1121: Device (UNC0) Warning 3073 - Multiple types (Device object requires either a _HID or _ADR, but not both)
This warning reported as error was ignored in older IASL versions. The address object (_ADR) is not needed because a valid hardware ID (_HID) for the device is available.
Change-Id: Iae5c91739ed9caea2dbb5996e2f093ed6fc47e93 Signed-off-by: Mario Scheithauer mario.scheithauer@siemens.com --- M src/mainboard/siemens/mc_bdx1/dsdt.asl 1 file changed, 0 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/29/46129/1
diff --git a/src/mainboard/siemens/mc_bdx1/dsdt.asl b/src/mainboard/siemens/mc_bdx1/dsdt.asl index 1248703..76845f5 100644 --- a/src/mainboard/siemens/mc_bdx1/dsdt.asl +++ b/src/mainboard/siemens/mc_bdx1/dsdt.asl @@ -261,7 +261,6 @@ Return (0xff) }
- Name (_ADR, 0x00) Method (_STA, 0, NotSerialized) { Return (0xf)
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46129 )
Change subject: mb/siemens/mc_bdx1: Fix IASL warning reported as error ......................................................................
Patch Set 1: Code-Review+2
Stefan Reinauer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46129 )
Change subject: mb/siemens/mc_bdx1: Fix IASL warning reported as error ......................................................................
Patch Set 1: Code-Review+2
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46129 )
Change subject: mb/siemens/mc_bdx1: Fix IASL warning reported as error ......................................................................
Patch Set 1: Code-Review+2
Christian Walter has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46129 )
Change subject: mb/siemens/mc_bdx1: Fix IASL warning reported as error ......................................................................
Patch Set 1: Code-Review+2
Werner Zeh has submitted this change. ( https://review.coreboot.org/c/coreboot/+/46129 )
Change subject: mb/siemens/mc_bdx1: Fix IASL warning reported as error ......................................................................
mb/siemens/mc_bdx1: Fix IASL warning reported as error
Latest IASL version (20200717) leads to a build error on 4.11_branch.
dsdt.asl 1121: Device (UNC0) Warning 3073 - Multiple types (Device object requires either a _HID or _ADR, but not both)
This warning reported as error was ignored in older IASL versions. The address object (_ADR) is not needed because a valid hardware ID (_HID) for the device is available.
Change-Id: Iae5c91739ed9caea2dbb5996e2f093ed6fc47e93 Signed-off-by: Mario Scheithauer mario.scheithauer@siemens.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/46129 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: HAOUAS Elyes ehaouas@noos.fr Reviewed-by: Stefan Reinauer stefan.reinauer@coreboot.org Reviewed-by: Angel Pons th3fanbus@gmail.com Reviewed-by: Christian Walter christian.walter@9elements.com --- M src/mainboard/siemens/mc_bdx1/dsdt.asl 1 file changed, 0 insertions(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Stefan Reinauer: Looks good to me, approved HAOUAS Elyes: Looks good to me, approved Angel Pons: Looks good to me, approved Christian Walter: Looks good to me, approved
diff --git a/src/mainboard/siemens/mc_bdx1/dsdt.asl b/src/mainboard/siemens/mc_bdx1/dsdt.asl index 1248703..76845f5 100644 --- a/src/mainboard/siemens/mc_bdx1/dsdt.asl +++ b/src/mainboard/siemens/mc_bdx1/dsdt.asl @@ -261,7 +261,6 @@ Return (0xff) }
- Name (_ADR, 0x00) Method (_STA, 0, NotSerialized) { Return (0xf)
-
Angel Pons (Code Review) -
Christian Walter (Code Review)
-
HAOUAS Elyes (Code Review)
-
Mario Scheithauer (Code Review)
-
Stefan Reinauer (Code Review)
-
Werner Zeh (Code Review)