Change in coreboot[master]: soc/amd/stoneyridge/chip.h: remove unneeded extern pci_domain_ops
Felix Held has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/48318 )
Change subject: soc/amd/stoneyridge/chip.h: remove unneeded extern pci_domain_ops ......................................................................
soc/amd/stoneyridge/chip.h: remove unneeded extern pci_domain_ops
Now pci_domain_ops in chip.c can also be marked as static.
Change-Id: I5e481fe311c9db4aacfd94bbf671edf679528946 Signed-off-by: Felix Held felix-coreboot@felixheld.de --- M src/soc/amd/stoneyridge/chip.c M src/soc/amd/stoneyridge/chip.h 2 files changed, 1 insertion(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/18/48318/1
diff --git a/src/soc/amd/stoneyridge/chip.c b/src/soc/amd/stoneyridge/chip.c index 909b847..e8bc71a 100644 --- a/src/soc/amd/stoneyridge/chip.c +++ b/src/soc/amd/stoneyridge/chip.c @@ -95,7 +95,7 @@ } };
-struct device_operations pci_domain_ops = { +static struct device_operations pci_domain_ops = { .read_resources = domain_read_resources, .set_resources = pci_domain_set_resources, .enable_resources = domain_enable_resources, diff --git a/src/soc/amd/stoneyridge/chip.h b/src/soc/amd/stoneyridge/chip.h index e72e3c0..566c359 100644 --- a/src/soc/amd/stoneyridge/chip.h +++ b/src/soc/amd/stoneyridge/chip.h @@ -68,6 +68,4 @@
typedef struct soc_amd_stoneyridge_config config_t;
-extern struct device_operations pci_domain_ops; - #endif /* __STONEYRIDGE_CHIP_H__ */
Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48318 )
Change subject: soc/amd/stoneyridge/chip.h: remove unneeded extern pci_domain_ops ......................................................................
Patch Set 1: Code-Review+2
Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/48318 )
Change subject: soc/amd/stoneyridge/chip.h: remove unneeded extern pci_domain_ops ......................................................................
soc/amd/stoneyridge/chip.h: remove unneeded extern pci_domain_ops
Now pci_domain_ops in chip.c can also be marked as static.
Change-Id: I5e481fe311c9db4aacfd94bbf671edf679528946 Signed-off-by: Felix Held felix-coreboot@felixheld.de Reviewed-on: https://review.coreboot.org/c/coreboot/+/48318 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Marshall Dawson marshalldawson3rd@gmail.com --- M src/soc/amd/stoneyridge/chip.c M src/soc/amd/stoneyridge/chip.h 2 files changed, 1 insertion(+), 3 deletions(-)
Approvals: build bot (Jenkins): Verified Marshall Dawson: Looks good to me, approved
diff --git a/src/soc/amd/stoneyridge/chip.c b/src/soc/amd/stoneyridge/chip.c index 909b847..e8bc71a 100644 --- a/src/soc/amd/stoneyridge/chip.c +++ b/src/soc/amd/stoneyridge/chip.c @@ -95,7 +95,7 @@ } };
-struct device_operations pci_domain_ops = { +static struct device_operations pci_domain_ops = { .read_resources = domain_read_resources, .set_resources = pci_domain_set_resources, .enable_resources = domain_enable_resources, diff --git a/src/soc/amd/stoneyridge/chip.h b/src/soc/amd/stoneyridge/chip.h index e72e3c0..566c359 100644 --- a/src/soc/amd/stoneyridge/chip.h +++ b/src/soc/amd/stoneyridge/chip.h @@ -68,6 +68,4 @@
typedef struct soc_amd_stoneyridge_config config_t;
-extern struct device_operations pci_domain_ops; - #endif /* __STONEYRIDGE_CHIP_H__ */
-
Felix Held (Code Review) -
Marshall Dawson (Code Review)