Felix Singer has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/32047
Change subject: soc/apl: Add HdAudioDspUaaCompliance to devicetree ......................................................................
soc/apl: Add HdAudioDspUaaCompliance to devicetree
Change-Id: I1522ae81cba5fc08605f4eb349b2977facd3f669 Signed-off-by: Felix Singer felix.singer@9elements.com --- M src/soc/intel/apollolake/chip.c M src/soc/intel/apollolake/chip.h 2 files changed, 4 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/47/32047/1
diff --git a/src/soc/intel/apollolake/chip.c b/src/soc/intel/apollolake/chip.c index 30a537b..5f83906 100644 --- a/src/soc/intel/apollolake/chip.c +++ b/src/soc/intel/apollolake/chip.c @@ -741,6 +741,8 @@ /* Disable FSP from locking access to the RTC NVRAM */ silconfig->RtcLock = 0;
+ silconfig->HdAudioDspUaaCompliance = cfg->hdaudio_dsp_uaa_compliance; + /* Enable Audio clk gate and power gate */ silconfig->HDAudioClkGate = cfg->hdaudio_clk_gate_enable; silconfig->HDAudioPwrGate = cfg->hdaudio_pwr_gate_enable; diff --git a/src/soc/intel/apollolake/chip.h b/src/soc/intel/apollolake/chip.h index b9e368c..e3bcfe5 100644 --- a/src/soc/intel/apollolake/chip.h +++ b/src/soc/intel/apollolake/chip.h @@ -127,6 +127,8 @@ uint8_t hdaudio_pwr_gate_enable; uint8_t hdaudio_bios_config_lockdown;
+ uint8_t hdaudio_dsp_uaa_compliance; + /* SLP S3 minimum assertion width. */ int slp_s3_assertion_width_usecs;
Hello Patrick Rudolph, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/32047
to look at the new patch set (#2).
Change subject: soc/apl: Add HdAudioDspUaaCompliance to devicetree ......................................................................
soc/apl: Add HdAudioDspUaaCompliance to devicetree
Change-Id: I1522ae81cba5fc08605f4eb349b2977facd3f669 Signed-off-by: Felix Singer felix.singer@9elements.com --- M src/soc/intel/apollolake/chip.c M src/soc/intel/apollolake/chip.h 2 files changed, 19 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/47/32047/2
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32047 )
Change subject: soc/apl: Add several audio options to devicetree ......................................................................
Patch Set 4:
This change is ready for review.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32047 )
Change subject: soc/apl: Add several audio options to devicetree ......................................................................
Patch Set 4:
Again, why is it useful to set those?
Is there a general rule to have all FSP options be configurable in coreboot? If yes, when updating FSP a corresponding commit should be required in the future?
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32047 )
Change subject: soc/apl: Add several audio options to devicetree ......................................................................
Patch Set 4:
Patch Set 4:
Again, why is it useful to set those?
Is there a general rule to have all FSP options be configurable in coreboot?
In general I think it should be possible that most (not all) of the FSP options are configureable by the mainboard. Because they are existing and why not?
Also, some of them are configured for my mainboard through slimbootloader.
Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32047 )
Change subject: soc/apl: Add several audio options to devicetree ......................................................................
Patch Set 4:
(2 comments)
https://review.coreboot.org/#/c/32047/4/src/soc/intel/apollolake/chip.c File src/soc/intel/apollolake/chip.c:
https://review.coreboot.org/#/c/32047/4/src/soc/intel/apollolake/chip.c@746 PS4, Line 746: silconfig->DspEndpointDmic = cfg->dsp_endpoint_dmic; that would overwrite the default of 1
https://review.coreboot.org/#/c/32047/4/src/soc/intel/apollolake/chip.c@747 PS4, Line 747: silconfig->DspEndpointBluetooth = cfg->dsp_endpoint_bluetooth; that would overwrite the default of 1
Felix Singer has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/32047 )
Change subject: soc/apl: Add several audio options to devicetree ......................................................................
Abandoned
-
Felix Singer (Code Review) -
Patrick Rudolph (Code Review)
-
Paul Menzel (Code Review)