Attention is currently required from: Felix Singer, Karthik Ramasubramanian, Martin L Roth, Raul Rangel.
Jon Murphy has posted comments on this change by Jon Murphy. ( https://review.coreboot.org/c/coreboot/+/85275?usp=email )
Change subject: util/crossgcc: Add libstdcxx target
......................................................................
Patch Set 11:
(3 comments)
File util/crossgcc/buildgcc:
https://review.coreboot.org/c/coreboot/+/85275/comment/6298449f_d4adf191?usp... :
PS11, Line 841: ${EXTRA_ARGS}
Can we drop the EXTRA_ARGS and just pass `$@` here?
Done
https://review.coreboot.org/c/coreboot/+/85275/comment/361261d7_c91f4660?usp... :
PS11, Line 845: set -- ""
: EXTRA_ARGS="$@"
Doesn't this set `EXTRA_ARGS=""`?
Yes, was trying to keep the style aligned between functions
https://review.coreboot.org/c/coreboot/+/85275/comment/ff7b0c5a_95a579b1?usp... :
PS11, Line 867: set -- "--with-gxx-include-dir="${LIBSTDCXX_INCLUDE_PATH}/coreboot-${TARGETARCH}/include/"
: --with-sysroot="${LIBSTDCXX_INCLUDE_PATH}/""
: EXTRA_ARGS="$@"
: configure_GCC "${EXTRA_ARGS}"
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/85275?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ie0c06ffaeab632c27a992dee8abcc403cceabeed
Gerrit-Change-Number: 85275
Gerrit-PatchSet: 11
Gerrit-Owner: Jon Murphy
jpmurphy@google.com
Gerrit-Reviewer: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Martin L Roth
gaumless@gmail.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Elyes Haouas
ehaouas@noos.fr
Gerrit-Attention: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Martin L Roth
gaumless@gmail.com
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Comment-Date: Mon, 16 Dec 2024 20:57:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Raul Rangel
rrangel@chromium.org