HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/33817
Change subject: include/cpu/x86/mtrr: Fix return type ......................................................................
include/cpu/x86/mtrr: Fix return type
Change-Id: Ia328e1e5a79c2e7606961bb1b68c01db6b77da21 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/include/cpu/x86/mtrr.h 1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/17/33817/1
diff --git a/src/include/cpu/x86/mtrr.h b/src/include/cpu/x86/mtrr.h index 49ed462..29256c8 100644 --- a/src/include/cpu/x86/mtrr.h +++ b/src/include/cpu/x86/mtrr.h @@ -120,7 +120,7 @@ /* fms: find most significant bit set, stolen from Linux Kernel Source. */ static inline unsigned int fms(unsigned int x) { - int r; + unsigned int r;
__asm__("bsrl %1,%0\n\t" "jnz 1f\n\t" @@ -132,7 +132,7 @@ /* fls: find least significant bit set */ static inline unsigned int fls(unsigned int x) { - int r; + unsigned int r;
__asm__("bsfl %1,%0\n\t" "jnz 1f\n\t"
Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33817 )
Change subject: include/cpu/x86/mtrr: Fix return type ......................................................................
Patch Set 1: Code-Review+1
The two don't belong in cpu/mtrr.h header, arch/cpu.h or arch/byteorder.h?
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33817 )
Change subject: include/cpu/x86/mtrr: Fix return type ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/#/c/33817/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/33817/1//COMMIT_MSG@8 PS1, Line 8: Please elaborate.
Hello Kyösti Mälkki, Arthur Heymans, Jacob Garber, build bot (Jenkins), Nico Huber,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/33817
to look at the new patch set (#2).
Change subject: include/cpu/x86/mtrr: Fix return type ......................................................................
include/cpu/x86/mtrr: Fix return type
fms() and fls() returns an 'unsigned int'.
Change-Id: Ia328e1e5a79c2e7606961bb1b68c01db6b77da21 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/include/cpu/x86/mtrr.h 1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/17/33817/2
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33817 )
Change subject: include/cpu/x86/mtrr: Fix return type ......................................................................
Patch Set 2: Code-Review+2
Nico Huber has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/33817 )
Change subject: include/cpu/x86/mtrr: Fix return type ......................................................................
include/cpu/x86/mtrr: Fix return type
fms() and fls() returns an 'unsigned int'.
Change-Id: Ia328e1e5a79c2e7606961bb1b68c01db6b77da21 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr Reviewed-on: https://review.coreboot.org/c/coreboot/+/33817 Reviewed-by: Nico Huber nico.h@gmx.de Reviewed-by: Kyösti Mälkki kyosti.malkki@gmail.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/include/cpu/x86/mtrr.h 1 file changed, 2 insertions(+), 2 deletions(-)
Approvals: build bot (Jenkins): Verified Kyösti Mälkki: Looks good to me, but someone else must approve Nico Huber: Looks good to me, approved
diff --git a/src/include/cpu/x86/mtrr.h b/src/include/cpu/x86/mtrr.h index 49ed462..29256c8 100644 --- a/src/include/cpu/x86/mtrr.h +++ b/src/include/cpu/x86/mtrr.h @@ -120,7 +120,7 @@ /* fms: find most significant bit set, stolen from Linux Kernel Source. */ static inline unsigned int fms(unsigned int x) { - int r; + unsigned int r;
__asm__("bsrl %1,%0\n\t" "jnz 1f\n\t" @@ -132,7 +132,7 @@ /* fls: find least significant bit set */ static inline unsigned int fls(unsigned int x) { - int r; + unsigned int r;
__asm__("bsfl %1,%0\n\t" "jnz 1f\n\t"