Change in ...coreboot[master]: include/cpu/x86/mtrr: Fix return type

List overview All Threads
Download

newer

older

Change in coreboot[master]:...

HAOUAS Elyes (Code Review)

26 Jun 2019 26 Jun '19

7:06 p.m.

HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/33817

Change subject: include/cpu/x86/mtrr: Fix return type ......................................................................

include/cpu/x86/mtrr: Fix return type

Change-Id: Ia328e1e5a79c2e7606961bb1b68c01db6b77da21 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/include/cpu/x86/mtrr.h 1 file changed, 2 insertions(+), 2 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/17/33817/1

diff --git a/src/include/cpu/x86/mtrr.h b/src/include/cpu/x86/mtrr.h index 49ed462..29256c8 100644 --- a/src/include/cpu/x86/mtrr.h +++ b/src/include/cpu/x86/mtrr.h @@ -120,7 +120,7 @@ /* fms: find most significant bit set, stolen from Linux Kernel Source. */ static inline unsigned int fms(unsigned int x) { - int r; + unsigned int r;

__asm__("bsrl %1,%0\n\t" "jnz 1f\n\t" @@ -132,7 +132,7 @@ /* fls: find least significant bit set */ static inline unsigned int fls(unsigned int x) { - int r; + unsigned int r;

__asm__("bsfl %1,%0\n\t" "jnz 1f\n\t"

Attachments:

attachment.htm (text/html — 2.7 KB)

Show replies by thread

Kyösti Mälkki (Code Review)

26 Jun 26 Jun

10:56 p.m.

Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33817 )

Change subject: include/cpu/x86/mtrr: Fix return type ......................................................................

Patch Set 1: Code-Review+1

The two don't belong in cpu/mtrr.h header, arch/cpu.h or arch/byteorder.h?

-- To view, visit https://review.coreboot.org/c/coreboot/+/33817 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia328e1e5a79c2e7606961bb1b68c01db6b77da21 Gerrit-Change-Number: 33817 Gerrit-PatchSet: 1 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Jacob Garber jgarber1@ualberta.ca Gerrit-Reviewer: Kyösti Mälkki kyosti.malkki@gmail.com Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Wed, 26 Jun 2019 22:56:17 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Paul Menzel (Code Review)

27 Jun 27 Jun

2:32 p.m.

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33817 )

Change subject: include/cpu/x86/mtrr: Fix return type ......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/#/c/33817/1//COMMIT_MSG Commit Message:

https://review.coreboot.org/#/c/33817/1//COMMIT_MSG@8 PS1, Line 8: Please elaborate.

-- To view, visit https://review.coreboot.org/c/coreboot/+/33817 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia328e1e5a79c2e7606961bb1b68c01db6b77da21 Gerrit-Change-Number: 33817 Gerrit-PatchSet: 1 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Jacob Garber jgarber1@ualberta.ca Gerrit-Reviewer: Kyösti Mälkki kyosti.malkki@gmail.com Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Thu, 27 Jun 2019 14:32:32 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

HAOUAS Elyes (Code Review)

3:49 p.m.

Hello Kyösti Mälkki, Arthur Heymans, Jacob Garber, build bot (Jenkins), Nico Huber,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/33817

to look at the new patch set (#2).

Change subject: include/cpu/x86/mtrr: Fix return type ......................................................................

include/cpu/x86/mtrr: Fix return type

fms() and fls() returns an 'unsigned int'.

Change-Id: Ia328e1e5a79c2e7606961bb1b68c01db6b77da21 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/include/cpu/x86/mtrr.h 1 file changed, 2 insertions(+), 2 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/17/33817/2

-- To view, visit https://review.coreboot.org/c/coreboot/+/33817 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia328e1e5a79c2e7606961bb1b68c01db6b77da21 Gerrit-Change-Number: 33817 Gerrit-PatchSet: 2 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Jacob Garber jgarber1@ualberta.ca Gerrit-Reviewer: Kyösti Mälkki kyosti.malkki@gmail.com Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: newpatchset

Nico Huber (Code Review)

7 Jul 7 Jul

12:23 a.m.

New subject: Change in coreboot[master]: include/cpu/x86/mtrr: Fix return type

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33817 )

Change subject: include/cpu/x86/mtrr: Fix return type ......................................................................

Patch Set 2: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/33817 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia328e1e5a79c2e7606961bb1b68c01db6b77da21 Gerrit-Change-Number: 33817 Gerrit-PatchSet: 2 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Jacob Garber jgarber1@ualberta.ca Gerrit-Reviewer: Kyösti Mälkki kyosti.malkki@gmail.com Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Sun, 07 Jul 2019 00:23:38 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Nico Huber (Code Review)

12:23 a.m.

New subject: Change in coreboot[master]: include/cpu/x86/mtrr: Fix return type

Nico Huber has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/33817 )

Change subject: include/cpu/x86/mtrr: Fix return type ......................................................................

include/cpu/x86/mtrr: Fix return type

fms() and fls() returns an 'unsigned int'.

Change-Id: Ia328e1e5a79c2e7606961bb1b68c01db6b77da21 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr Reviewed-on: https://review.coreboot.org/c/coreboot/+/33817 Reviewed-by: Nico Huber nico.h@gmx.de Reviewed-by: Kyösti Mälkki kyosti.malkki@gmail.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/include/cpu/x86/mtrr.h 1 file changed, 2 insertions(+), 2 deletions(-)

Approvals: build bot (Jenkins): Verified Kyösti Mälkki: Looks good to me, but someone else must approve Nico Huber: Looks good to me, approved

__asm__("bsrl %1,%0\n\t" "jnz 1f\n\t" @@ -132,7 +132,7 @@ /* fls: find least significant bit set */ static inline unsigned int fls(unsigned int x) { - int r; + unsigned int r;

__asm__("bsfl %1,%0\n\t" "jnz 1f\n\t"

-- To view, visit https://review.coreboot.org/c/coreboot/+/33817 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia328e1e5a79c2e7606961bb1b68c01db6b77da21 Gerrit-Change-Number: 33817 Gerrit-PatchSet: 3 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Jacob Garber jgarber1@ualberta.ca Gerrit-Reviewer: Kyösti Mälkki kyosti.malkki@gmail.com Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: merged

1781

days inactive

1792

days old

coreboot-gerrit@coreboot.org

5 comments

4 participants

tags (0)

participants (4)

HAOUAS Elyes (Code Review)
Kyösti Mälkki (Code Review)
Nico Huber (Code Review)
Paul Menzel (Code Review)