Attention is currently required from: Hou-hsun Lee, Paul Menzel, Nick Vaccaro, Zhuohao Lee.
Alan Huang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58241 )
Change subject: mb/google/brya/var/baseboard/brask: Add power limits functions
......................................................................
Patch Set 15:
(2 comments)
Patchset:
PS15:
Removed psys_pmax_power from struct system_power_limits as the field is actually not used.
Added more comments in variants.h for function variants_update_psys_power_limits
File src/mainboard/google/brya/variants/baseboard/brask/ramstage.c:
https://review.coreboot.org/c/coreboot/+/58241/comment/683f729b_b0056f7d
PS14, Line 108: soc_config->tdp_pl4 = 0;
You set tdp_pl4 to 0 here, which means you must call variant_update_psys_power_limits() first, then […]
Yes, it's correct. Added comments in variants.h.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/58241
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I183017068e9c78acb9fa7073c53593d304ba9248
Gerrit-Change-Number: 58241
Gerrit-PatchSet: 15
Gerrit-Owner: Alan Huang
alan-huang@quanta.corp-partner.google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Zhuohao Lee
zhuohao@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: David Wu
david_wu@quanta.corp-partner.google.com
Gerrit-CC: Hou-hsun Lee
hou-hsun.lee@intel.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Hou-hsun Lee
hou-hsun.lee@intel.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Nick Vaccaro
nvaccaro@google.com
Gerrit-Attention: Zhuohao Lee
zhuohao@google.com
Gerrit-Comment-Date: Fri, 26 Nov 2021 10:40:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Hou-hsun Lee
hou-hsun.lee@intel.com
Gerrit-MessageType: comment