Attention is currently required from: EliasOfWaffle, Jérémy Compostella, Martin L Roth, Matt DeVillier, Michał Żygowski, Paul Menzel, Stefan Reinauer.
Eugene Myers has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78889?usp=email )
Change subject: cpu/x86/smm: Fix get_save_state calculation ......................................................................
Patch Set 4:
(5 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/78889/comment/cfdd58d6_9f21364e : PS1, Line 9: When the STM is configured, get_save_state returns an incorrect
nit: This is more of my rule as I don't think I saw that in coreboot coding style but I usually feel […]
Done
Patchset:
PS4: I opted not to change the code (the suggestion actually contained a bug should be "size -= ALIGN...") - I would still have to test it to make sure.
File src/cpu/x86/smm/smm_module_handler.c:
https://review.coreboot.org/c/coreboot/+/78889/comment/43c56985_7f2973d7 : PS1, Line 12: #include <security/intel/stm/SmmStm.h>
includes are usually sorted in alphabetical order.
Done
https://review.coreboot.org/c/coreboot/+/78889/comment/6b6c1b5c_b67d5729 : PS1, Line 104: size_t stm_psd_size = 0;
Acknowledged
https://review.coreboot.org/c/coreboot/+/78889/comment/80f7ec82_08ac75c2 : PS1, Line 111: 0x100);
It should fit on one line. The coding style states 96 columns.
Acknowledged
-
Eugene Myers (Code Review)