Attention is currently required from: Angel Pons, Nicholas Chin.
Riku Viitanen has posted comments on this change by Riku Viitanen. ( https://review.coreboot.org/c/coreboot/+/85832?usp=email )
Change subject: mb/asus/h61-series: Add P8H67-I DELUXE variant ......................................................................
Patch Set 8:
(6 comments)
File src/mainboard/asus/h61-series/variants/p8h67-i_deluxe/early_init.c:
https://review.coreboot.org/c/coreboot/+/85832/comment/4439c7f3_884f51db?usp... : PS7, Line 8: PCI_DEV(0, 0x1f, 0), 0x82, 0x3f00
Could be replaced with macros in `sb/intel/bd82x6x/pch.h`: […]
Done
https://review.coreboot.org/c/coreboot/+/85832/comment/866e7018_1e7127af?usp... : PS7, Line 9: PCI_DEV(0, 0x1f, 0), 0x80, 0x0010
Same here: […]
removed
File src/mainboard/asus/h61-series/variants/p8h67-i_deluxe/overridetree.cb:
PS7:
Add SPDX header
Done
https://review.coreboot.org/c/coreboot/+/85832/comment/8e4a889a_615c65d2?usp... : PS7, Line 2: register "gpu_dp_b_hotplug" = "4" : register "gpu_dp_d_hotplug" = "4"
Move under igd
Done
https://review.coreboot.org/c/coreboot/+/85832/comment/d5871938_b80402c1?usp... : PS7, Line 40: subsystemid 0x1043 0x848d
It looks like it is possible to use a `subsystemid 0xnnnn 0xnnnn inherit` and then still specify a s […]
Done
https://review.coreboot.org/c/coreboot/+/85832/comment/18576708_be78afe1?usp... : PS7, Line 62: device ref pci_bridge off end
Defaults to off in chipset devicetree and can be removed from the overridetree
Done