Attention is currently required from: Martin Roth, Zheng Bao, Felix Held.
Bao Zheng has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57131 )
Change subject: amdfwtool: Add support for AMD's BIOS recovery feature
......................................................................
Patch Set 49:
(3 comments)
File util/amdfwtool/amdfwtool.c:
https://review.coreboot.org/c/coreboot/+/57131/comment/dd8e6a6e_e77f3c5f
PS49, Line 587: uint32_t index;
:
: index = 0;
i'd combine those two lines into uint32_t index = 0;
Done
https://review.coreboot.org/c/coreboot/+/57131/comment/4685935d_603326e1
PS49, Line 592: break;
you could do a return index instead of the break here and replace the if/else construct in lines 596 […]
Done
https://review.coreboot.org/c/coreboot/+/57131/comment/d0753226_795c0d3c
PS49, Line 1899: 0x20000
should this be TABLE_ALIGNMENT?
should be the size of FW
--
To view, visit
https://review.coreboot.org/c/coreboot/+/57131
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2671b95fe089aafdaf61b55bc9d2e8dcf6a66dbc
Gerrit-Change-Number: 57131
Gerrit-PatchSet: 49
Gerrit-Owner: Bao Zheng
fishbaozi@gmail.com
Gerrit-Reviewer: Zheng Bao
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Bao Zheng
zheng.bao@amd.corp-partner.google.com
Gerrit-CC: Felix Held
felix-coreboot@felixheld.de
Gerrit-CC: Martin Roth
martinroth@google.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Martin Roth
martinroth@google.com
Gerrit-Attention: Zheng Bao
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Sat, 26 Mar 2022 08:05:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Held
felix-coreboot@felixheld.de
Gerrit-MessageType: comment