Raul Rangel has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/50011 )
Change subject: [HACK][WIP] mb/google/zork: Remove all GPE wake sources ......................................................................
[HACK][WIP] mb/google/zork: Remove all GPE wake sources
Windows throws a BSOD if an ACPI device uses GpioInt in the _CRS and a GPE in the _PRW. See https://docs.microsoft.com/en-us/windows-hardware/drivers/debugger/bug-check... Error Code 0x1000D
I'm still not sure what the correct way to solve this is.
BUG=b:175146875 TEST=Boot to windows
Signed-off-by: Raul E Rangel rrangel@chromium.org Change-Id: Ia701339790c8d8b5e5c574bcfcce828e0afaaf38 --- M src/mainboard/google/zork/variants/baseboard/devicetree_trembyle.cb M src/mainboard/google/zork/variants/baseboard/include/baseboard/ec.h M src/mainboard/google/zork/variants/trembyle/overridetree.cb 3 files changed, 5 insertions(+), 5 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/11/50011/1
diff --git a/src/mainboard/google/zork/variants/baseboard/devicetree_trembyle.cb b/src/mainboard/google/zork/variants/baseboard/devicetree_trembyle.cb index 40e2ed5..1d8d85a 100644 --- a/src/mainboard/google/zork/variants/baseboard/devicetree_trembyle.cb +++ b/src/mainboard/google/zork/variants/baseboard/devicetree_trembyle.cb @@ -212,7 +212,7 @@ device pci 1.1 off end # GPP Bridge 0 device pci 1.2 on # GPP Bridge 1 - Wifi chip drivers/wifi/generic - register "wake" = "GEVENT_8" + # register "wake" = "GEVENT_8" device pci 00.0 on end end end diff --git a/src/mainboard/google/zork/variants/baseboard/include/baseboard/ec.h b/src/mainboard/google/zork/variants/baseboard/include/baseboard/ec.h index 46177fc..b1ce420 100644 --- a/src/mainboard/google/zork/variants/baseboard/include/baseboard/ec.h +++ b/src/mainboard/google/zork/variants/baseboard/include/baseboard/ec.h @@ -52,7 +52,7 @@
/* Enable LID switch */ #define EC_ENABLE_LID_SWITCH -#define EC_ENABLE_WAKE_PIN EC_WAKE_GPI +// #define EC_ENABLE_WAKE_PIN EC_WAKE_GPI
/* Enable EC backed ALS device in ACPI */ #define EC_ENABLE_ALS_DEVICE diff --git a/src/mainboard/google/zork/variants/trembyle/overridetree.cb b/src/mainboard/google/zork/variants/trembyle/overridetree.cb index de38ab7..2abbd46 100644 --- a/src/mainboard/google/zork/variants/trembyle/overridetree.cb +++ b/src/mainboard/google/zork/variants/trembyle/overridetree.cb @@ -51,7 +51,7 @@ register "hid" = ""ELAN0000"" register "desc" = ""ELAN Touchpad"" register "irq_gpio" = "ACPI_GPIO_IRQ_EDGE_LOW(GPIO_9)" - register "wake" = "GEVENT_22" + # register "wake" = "GEVENT_22" register "probed" = "1" device i2c 15 on end end @@ -59,7 +59,7 @@ register "generic.hid" = ""PNP0C50"" register "generic.desc" = ""Synaptics Touchpad"" register "generic.irq_gpio" = "ACPI_GPIO_IRQ_LEVEL_LOW(GPIO_9)" - register "generic.wake" = "GEVENT_22" + # register "generic.wake" = "GEVENT_22" register "generic.probed" = "1" register "hid_desc_reg_offset" = "0x20" device i2c 2c on end @@ -98,7 +98,7 @@ register "hid" = "ACPI_DT_NAMESPACE_HID" register "compat_string" = ""google,cros-ec-uart"" register "irq_gpio" = "ACPI_GPIO_IRQ_LEVEL_LOW(GPIO_6)" - register "wake" = "GEVENT_10" + # register "wake" = "GEVENT_10" register "uart" = "ACPI_UART_RAW_DEVICE(3000000, 64)" device generic 0 on end end