Martin Roth has posted comments on this change. ( https://review.coreboot.org/19954 )
Change subject: sb/intel/bd82x6x/early_usb: Use register name ......................................................................
Patch Set 2: Code-Review+2
(1 comment)
https://review.coreboot.org/#/c/19954/1/src/southbridge/intel/bd82x6x/early_... File src/southbridge/intel/bd82x6x/early_usb.c:
PS1, Line 74: inw(DEFAULT_PMBASE | UPRWC) & ~UPRWC_WR_EN
your commit description is "Use register name" but this commit actually doe
Agreed. It just needs a bit more in the commit message.