[S] Change in coreboot[master]: mb/google/skyrim: Enable STB Spill-to-DRAM by default - coreboot-gerrit

16 Nov 2022


      Attention is currently required from: Martin L Roth, Jason Nien, Jon Murphy, Martin Roth, Tim Van Patten.
Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69707 )
Change subject: mb/google/skyrim: Enable STB Spill-to-DRAM by default
......................................................................
Patch Set 1:
(1 comment)
File src/mainboard/google/skyrim/Kconfig:
https://review.coreboot.org/c/coreboot/+/69707/comment/07232ef3_a5910bd2 
PS1, Line 157: 
Nit: Extra 2 lines are being added. Also I think we can just select it under BOARD_SPECIFIC_OPTIONS. Help text is already available under soc/amd/common/block/stb/Kconfig for this config.
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/69707
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib60b7fc2ba85c7a8025c9f8c6495e94049499f56
Gerrit-Change-Number: 69707
Gerrit-PatchSet: 1
Gerrit-Owner: Martin L Roth gaumless@gmail.com
Gerrit-Reviewer: Jason Nien jason.nien@amd.corp-partner.google.com
Gerrit-Reviewer: Jon Murphy jpmurphy@google.com
Gerrit-Reviewer: Martin Roth martin.roth@amd.corp-partner.google.com
Gerrit-Reviewer: Tim Van Patten timvp@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Karthik Ramasubramanian kramasub@google.com
Gerrit-Attention: Martin L Roth gaumless@gmail.com
Gerrit-Attention: Jason Nien jason.nien@amd.corp-partner.google.com
Gerrit-Attention: Jon Murphy jpmurphy@google.com
Gerrit-Attention: Martin Roth martin.roth@amd.corp-partner.google.com
Gerrit-Attention: Tim Van Patten timvp@google.com
Gerrit-Comment-Date: Wed, 16 Nov 2022 19:46:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment