Attention is currently required from: Patrick Rudolph, Simon Chou, Johnny Lin, Paul Menzel, Shuming Chu (Shuming), Arthur Heymans, Juan Sanchez.
Lean Sheng Tan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/71968 )
Change subject: mb/intel: add Archer City CRB support
......................................................................
Patch Set 28:
(1 comment)
File src/mainboard/intel/archercity_crb/romstage.c:
https://review.coreboot.org/c/coreboot/+/71968/comment/9814c9d4_31690a84
PS27, Line 96: "SerialIoUartDebugEnable to %d\n", FSP_LOG, FSP_LOG_DEFAULT);
Exceeding the limit is allowed for print strings. The reasoning is, that it’s easier to grep.
hi Paul do you have any example as reference? or where is this documented in guideline? thanks.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/71968
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic02634cd615e2245e394f10aad24b0430cf5cd17
Gerrit-Change-Number: 71968
Gerrit-PatchSet: 28
Gerrit-Owner: Simon Chou
simonchou@supermicro.com.tw
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Reviewer: Jonathan Zhang
jon.zhixiong.zhang@gmail.com
Gerrit-Reviewer: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-CC: Daocheng Bu
daocheng.bu@intel.com
Gerrit-CC: Jingle Hsu
jingle_hsu@wiwynn.com
Gerrit-CC: Juan Sanchez
Gerrit-CC: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Shelly Chang
Shelly_Chang@wiwynn.com
Gerrit-CC: Shuming Chu (Shuming)
s1218944@gmail.com
Gerrit-CC: Srinidhi N Kaushik
srinidhi.n.kaushik@intel.com
Gerrit-CC: Tim Chu
Tim.Chu@quantatw.com
Gerrit-CC: Ziang Wang
ziang.wang@intel.com
Gerrit-Attention: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Attention: Simon Chou
simonchou@supermicro.com.tw
Gerrit-Attention: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Shuming Chu (Shuming)
s1218944@gmail.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Juan Sanchez
Gerrit-Comment-Date: Sat, 01 Apr 2023 09:26:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Johnny Lin
Johnny_Lin@wiwynn.com
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Gerrit-MessageType: comment