Attention is currently required from: Tim Wawrzynczak, Meera Ravindranath, Nick Vaccaro.
Maulik V Vaghela has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60320 )
Change subject: mb/google/brya: Change SD Card and Touch pad GPIO PAD_RST to RSMRST
......................................................................
Patch Set 3:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/60320/comment/6ec99c41_a5b35912
PS3, Line 10: default state while the GPIO locking register gets a reset only in
during warm reset.
GPIO lock configuration register
https://review.coreboot.org/c/coreboot/+/60320/comment/451877d8_8a89a0c1
PS3, Line 11: RSMRST which prevents enumeration of SD card and Touch pad in
Can you put more detail as to why it prevents enumeration?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/60320
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I558bab39f935ab31a89541c6498a73af70cbf9ee
Gerrit-Change-Number: 60320
Gerrit-PatchSet: 3
Gerrit-Owner: Meera Ravindranath
meera.ravindranath@intel.com
Gerrit-Reviewer: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Meera Ravindranath
meera.ravindranath@intel.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@google.com
Gerrit-Comment-Date: Thu, 23 Dec 2021 09:42:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment