Change in coreboot[master]: [Don't Merge] Performs disable for Serial Io UART0 Controller
Attention is currently required from: Tim Wawrzynczak, Patrick Rudolph. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55756 )
Change subject: [Don't Merge] Performs disable for Serial Io UART0 Controller ......................................................................
Patch Set 1:
(65 comments)
File src/soc/intel/alderlake/smihandler.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-122465): https://review.coreboot.org/c/coreboot/+/55756/comment/c4d283fb_e2e0b9bf PS1, Line 23: printk(BIOS_ERR, "UART 0 is calling \n"); unnecessary whitespace before a quoted newline
File src/soc/intel/common/block/cse/disable_heci.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-122465): https://review.coreboot.org/c/coreboot/+/55756/comment/6c8b413e_7e1acf0d PS1, Line 57: struct pcr_sbi_msg msg = { code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-122465): https://review.coreboot.org/c/coreboot/+/55756/comment/889a4a48_5837ecd3 PS1, Line 57: struct pcr_sbi_msg msg = { please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-122465): https://review.coreboot.org/c/coreboot/+/55756/comment/909c873f_41fe41ba PS1, Line 58: .pid = PID_SERIALIO, code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-122465): https://review.coreboot.org/c/coreboot/+/55756/comment/94ecbf03_5dce9447 PS1, Line 58: .pid = PID_SERIALIO, please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-122465): https://review.coreboot.org/c/coreboot/+/55756/comment/2ebdfffb_6172712f PS1, Line 59: .offset = 0xA0, code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-122465): https://review.coreboot.org/c/coreboot/+/55756/comment/1f6ed740_72eaa501 PS1, Line 59: .offset = 0xA0, please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-122465): https://review.coreboot.org/c/coreboot/+/55756/comment/9c45a29e_734952b1 PS1, Line 60: .opcode = PCR_WRITE, code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-122465): https://review.coreboot.org/c/coreboot/+/55756/comment/6ab02613_f55cba73 PS1, Line 60: .opcode = PCR_WRITE, please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-122465): https://review.coreboot.org/c/coreboot/+/55756/comment/2fe4dfe1_aca34881 PS1, Line 61: .is_posted = false, code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-122465): https://review.coreboot.org/c/coreboot/+/55756/comment/7595e794_094c4ee5 PS1, Line 61: .is_posted = false, please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-122465): https://review.coreboot.org/c/coreboot/+/55756/comment/9e637cd4_1f2ba5fa PS1, Line 62: .fast_byte_enable = UART0_FBE, code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-122465): https://review.coreboot.org/c/coreboot/+/55756/comment/250a22ca_f3b1a748 PS1, Line 62: .fast_byte_enable = UART0_FBE, please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-122465): https://review.coreboot.org/c/coreboot/+/55756/comment/ef24fa6d_e4c48428 PS1, Line 63: .bar = UART0_BAR, code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-122465): https://review.coreboot.org/c/coreboot/+/55756/comment/eca1e241_9475e298 PS1, Line 63: .bar = UART0_BAR, please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-122465): https://review.coreboot.org/c/coreboot/+/55756/comment/2786eb69_ab16674b PS1, Line 64: .fid = UART0_FID code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-122465): https://review.coreboot.org/c/coreboot/+/55756/comment/70847e54_012497fe PS1, Line 64: .fid = UART0_FID please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-122465): https://review.coreboot.org/c/coreboot/+/55756/comment/7b0532a3_cff47166 PS1, Line 65: }; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-122465): https://review.coreboot.org/c/coreboot/+/55756/comment/dc5a89bd_f10b65bb PS1, Line 65: }; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-122465): https://review.coreboot.org/c/coreboot/+/55756/comment/cf200d40_bbec9a5e PS1, Line 66: struct pcr_sbi_msg msg1 = { please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-122465): https://review.coreboot.org/c/coreboot/+/55756/comment/a5a7c095_f385fbe2 PS1, Line 67: .pid = PID_SERIALIO, code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-122465): https://review.coreboot.org/c/coreboot/+/55756/comment/0589ea19_b3bddbfe PS1, Line 67: .pid = PID_SERIALIO, please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-122465): https://review.coreboot.org/c/coreboot/+/55756/comment/c3bbe7c7_83e90148 PS1, Line 68: .offset = 0x84, code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-122465): https://review.coreboot.org/c/coreboot/+/55756/comment/21eaaab1_34fdd1d0 PS1, Line 68: .offset = 0x84, please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-122465): https://review.coreboot.org/c/coreboot/+/55756/comment/91460000_dd9b3df3 PS1, Line 69: .opcode = PCR_WRITE, code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-122465): https://review.coreboot.org/c/coreboot/+/55756/comment/68e342c5_660bfd29 PS1, Line 69: .opcode = PCR_WRITE, please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-122465): https://review.coreboot.org/c/coreboot/+/55756/comment/ce5d66bb_d5a86d62 PS1, Line 70: .is_posted = false, code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-122465): https://review.coreboot.org/c/coreboot/+/55756/comment/d6f52345_dcab2c4b PS1, Line 70: .is_posted = false, please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-122465): https://review.coreboot.org/c/coreboot/+/55756/comment/49ec77bb_5a6c1660 PS1, Line 71: .fast_byte_enable = UART0_FBE, code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-122465): https://review.coreboot.org/c/coreboot/+/55756/comment/ae551a45_d80418a3 PS1, Line 71: .fast_byte_enable = UART0_FBE, please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-122465): https://review.coreboot.org/c/coreboot/+/55756/comment/24a35e78_1c3b131e PS1, Line 72: .bar = UART0_BAR, code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-122465): https://review.coreboot.org/c/coreboot/+/55756/comment/1e806a6c_4e80a5bb PS1, Line 72: .bar = UART0_BAR, please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-122465): https://review.coreboot.org/c/coreboot/+/55756/comment/9e9757ba_a452c198 PS1, Line 73: .fid = UART0_FID code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-122465): https://review.coreboot.org/c/coreboot/+/55756/comment/7ddc53f1_5e87be9d PS1, Line 73: .fid = UART0_FID please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-122465): https://review.coreboot.org/c/coreboot/+/55756/comment/fde9cb17_74723c7d PS1, Line 74: }; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-122465): https://review.coreboot.org/c/coreboot/+/55756/comment/52c40760_c506c144 PS1, Line 74: }; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-122465): https://review.coreboot.org/c/coreboot/+/55756/comment/1bd098b7_80a82ead PS1, Line 76: /* Bit 16-18: Set to make UART0 Function disable */ code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-122465): https://review.coreboot.org/c/coreboot/+/55756/comment/5cb0e90c_823f5870 PS1, Line 77: uint32_t data32 = 0x70000; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-122465): https://review.coreboot.org/c/coreboot/+/55756/comment/7a156f77_134af33e PS1, Line 77: uint32_t data32 = 0x70000; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-122465): https://review.coreboot.org/c/coreboot/+/55756/comment/f82729d5_59801d0c PS1, Line 78: uint8_t response; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-122465): https://review.coreboot.org/c/coreboot/+/55756/comment/3e84a34b_36ef7066 PS1, Line 78: uint8_t response; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-122465): https://review.coreboot.org/c/coreboot/+/55756/comment/a423c8be_6fddb569 PS1, Line 79: int status; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-122465): https://review.coreboot.org/c/coreboot/+/55756/comment/1b930a43_8a3bc112 PS1, Line 79: int status; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-122465): https://review.coreboot.org/c/coreboot/+/55756/comment/f1a4b241_5eb3ef5c PS1, Line 81: /* unhide p2sb device */ code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-122465): https://review.coreboot.org/c/coreboot/+/55756/comment/0d7b9b16_ac2cae76 PS1, Line 82: p2sb_unhide(); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-122465): https://review.coreboot.org/c/coreboot/+/55756/comment/3c780cc6_dbc49615 PS1, Line 82: p2sb_unhide(); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-122465): https://review.coreboot.org/c/coreboot/+/55756/comment/3de09388_c12f3560 PS1, Line 85: /* Send SBI command to make HECI#1 function disable */ code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-122465): https://review.coreboot.org/c/coreboot/+/55756/comment/4a72d41f_57a31dd6 PS1, Line 86: status = pcr_execute_sideband_msg(&msg, &data32, &response); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-122465): https://review.coreboot.org/c/coreboot/+/55756/comment/f2bd9a02_1b07c00b PS1, Line 86: status = pcr_execute_sideband_msg(&msg, &data32, &response); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-122465): https://review.coreboot.org/c/coreboot/+/55756/comment/ee18e991_030db491 PS1, Line 87: if (status || response) code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-122465): https://review.coreboot.org/c/coreboot/+/55756/comment/0635f02a_03a18794 PS1, Line 87: if (status || response) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-122465): https://review.coreboot.org/c/coreboot/+/55756/comment/5b2476dc_11257f52 PS1, Line 88: printk(BIOS_ERR, "Fail to make UART0 function 0xA0 disable\n"); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-122465): https://review.coreboot.org/c/coreboot/+/55756/comment/e3426efb_3520ec3f PS1, Line 88: printk(BIOS_ERR, "Fail to make UART0 function 0xA0 disable\n"); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-122465): https://review.coreboot.org/c/coreboot/+/55756/comment/79cbb6ba_cae9a98a PS1, Line 94: status = pcr_execute_sideband_msg(&msg1, &data32, &response); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-122465): https://review.coreboot.org/c/coreboot/+/55756/comment/69e022e1_6e695624 PS1, Line 94: status = pcr_execute_sideband_msg(&msg1, &data32, &response); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-122465): https://review.coreboot.org/c/coreboot/+/55756/comment/ce493b88_c9d99a32 PS1, Line 95: if (status || response) code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-122465): https://review.coreboot.org/c/coreboot/+/55756/comment/277c0687_651761c5 PS1, Line 95: if (status || response) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-122465): https://review.coreboot.org/c/coreboot/+/55756/comment/89587eef_262ecdbe PS1, Line 96: printk(BIOS_ERR, "Fail to make UART0 function 0x84 disable\n"); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-122465): https://review.coreboot.org/c/coreboot/+/55756/comment/4c39ee19_2f28f524 PS1, Line 96: printk(BIOS_ERR, "Fail to make UART0 function 0x84 disable\n"); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-122465): https://review.coreboot.org/c/coreboot/+/55756/comment/91e4e569_24842686 PS1, Line 98: /* Ensure to Lock SBI interface after this command */ code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-122465): https://review.coreboot.org/c/coreboot/+/55756/comment/a81666bd_1ca9c734 PS1, Line 99: p2sb_disable_sideband_access(); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-122465): https://review.coreboot.org/c/coreboot/+/55756/comment/74778bd7_d7b8af12 PS1, Line 99: p2sb_disable_sideband_access(); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-122465): https://review.coreboot.org/c/coreboot/+/55756/comment/29bb2a01_2ab59e67 PS1, Line 101: /* hide p2sb device */ code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-122465): https://review.coreboot.org/c/coreboot/+/55756/comment/a2180cca_c6944152 PS1, Line 102: p2sb_hide(); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-122465): https://review.coreboot.org/c/coreboot/+/55756/comment/350b6786_bb70fb82 PS1, Line 102: p2sb_hide(); please, no spaces at the start of a line
-
build bot (Jenkins) (Code Review)