Attention is currently required from: Tim Wawrzynczak, Angel Pons, Subrata Banik, Aamir Bohra.
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50880 )
Change subject: intel/fsp2_0: Fix the mp_get_processor_info
......................................................................
Patch Set 4: Code-Review+2
(1 comment)
File src/drivers/intel/fsp2_0/ppi/mp_service_ppi.c:
https://review.coreboot.org/c/coreboot/+/50880/comment/1367e4bb_6706133d
PS4, Line 59: FSP will add one to the value in this Package field
I think this is true for package, core and thread. Not just for Package? Do we still need this comment?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/50880
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ief8677e4830a765af61a0df9621ecaa372730fca
Gerrit-Change-Number: 50880
Gerrit-PatchSet: 4
Gerrit-Owner: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Subrata Banik
subrata.banik@intel.com
Gerrit-Attention: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Comment-Date: Fri, 19 Feb 2021 18:30:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment