Attention is currently required from: Boris Mittelberg, Caveh Jalali, Jakub Czapiga, Julius Werner, Karthik Ramasubramanian, Nick Vaccaro, Nick Vaccaro, Yu-Ping Wu.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78076?usp=email )
Change subject: {lib, ec/google}: Add weak implementation for get_lid_switch()
......................................................................
Patch Set 4:
(1 comment)
File src/ec/google/chromeec/switches.c:
https://review.coreboot.org/c/coreboot/+/78076/comment/ca364f2c_018a98ad :
PS1, Line 9: if (!CONFIG(VBOOT_LID_SWITCH))
Verified Boot is used in non-ChromeOS boards too. Having said that, updating CB:78207 as below(something along that line) will limit the scope to Google main boards alone. That way you need to disable VBOOT_LID_SWITCH only for Chromeboxes and Chromebases.
config VBOOT_LID_SWITCH
bool
default y if EC_GOOGLE_CHROMEEC_SWITCHES
default n
<snip>
https://review.coreboot.org/c/coreboot/+/78207/5/src/security/vboot/Kconfig#...
--
To view, visit
https://review.coreboot.org/c/coreboot/+/78076?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I8847bc6f08f5d9cecf9d9ddaf33c44bd40491e98
Gerrit-Change-Number: 78076
Gerrit-PatchSet: 4
Gerrit-Owner: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Boris Mittelberg
bmbm@google.com
Gerrit-Reviewer: Caveh Jalali
caveh@chromium.org
Gerrit-Reviewer: Jakub Czapiga
jacz@semihalf.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Attention: Jakub Czapiga
jacz@semihalf.com
Gerrit-Attention: Caveh Jalali
caveh@chromium.org
Gerrit-Attention: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Attention: Nick Vaccaro
nvaccaro@google.com
Gerrit-Attention: Yu-Ping Wu
yupingso@google.com
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Attention: Boris Mittelberg
bmbm@google.com
Gerrit-Comment-Date: Mon, 02 Oct 2023 07:18:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Comment-In-Reply-To: Karthik Ramasubramanian
kramasub@google.com
Gerrit-MessageType: comment