Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/28336 )
Change subject: soc/cavium: Add dynamic dtb support ......................................................................
Patch Set 2:
(4 comments)
also set the default devicetree in payloads linux and linuxboot to $(obj)/fit.dtb if FIT_DEVICETREE_NAME != "" ?
https://review.coreboot.org/#/c/28336/2/Makefile.inc File Makefile.inc:
https://review.coreboot.org/#/c/28336/2/Makefile.inc@574 PS2, Line 574: FIT_DEVICETREE_FILE := $(src)/mainboard/$(MAINBOARDDIR)/$(FIT_DEVICETREE_NAME) $(src)/mainboard/$(MAINBOARDDIR)/$(VARIANT_DIR)/$(FIT_DEVICETREE_NAME)
https://review.coreboot.org/#/c/28336/2/Makefile.inc@582 PS2, Line 582: dtc -I dts -O dtb -o $@ -i $(src)/mainboard/$(MAINBOARDDIR) -i $(src)/mainboard/$(VARIANT_DIR) $< $(src)/mainboard/$(MAINBOARDDIR)/$(VARIANT_DIR)/
https://review.coreboot.org/#/c/28336/2/Makefile.inc@584 PS2, Line 584: cbfs-files-y += $(FIT_DEVICETREE_NAME) has nothing to do with FIT. Should be placed in soc/cavium/cn81xx and marked deprecated
https://review.coreboot.org/#/c/28336/2/src/mainboard/Kconfig File src/mainboard/Kconfig:
https://review.coreboot.org/#/c/28336/2/src/mainboard/Kconfig@186 PS2, Line 186: default "" Overwrite the default in src/mainboard/cavium/cn81xx_sff_evb
-
Patrick Rudolph (Code Review)