Attention is currently required from: Zhixing Ma, Anil Kumar K, Jérémy Compostella, Selma Bensaid, Nick Vaccaro, Tim Wawrzynczak.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/67466 )
Change subject: soc/intel/broadwell: Allow up to six microcodes in the FIT table
......................................................................
Patch Set 4: Code-Review+1
(3 comments)
Patchset:
PS4:
I made https://review.coreboot.org/q/topic:hsw-bdw-cpu-unification a while ago, so that Haswell and Broadwell use the same CPU code. I'd prefer to add this Kconfig value to `src/cpu/intel/haswell/Kconfig` as `src/cpu/intel/haswell/Makefile.inc` specifies the microcode updates to be added in coreboot.
File src/soc/intel/broadwell/Kconfig:
https://review.coreboot.org/c/coreboot/+/67466/comment/212e14b4_236e82aa
PS4, Line 26: CPU_INTEL_NUM_FIT_ENTRIES
Where is this used?
I see this being used in `src/cpu/intel/fit` and in `src/security/intel` (TXT/CBnT need to place several extra things in FIT, like ACMs).
https://review.coreboot.org/c/coreboot/+/67466/comment/f3743650_982a7246
PS4, Line 27: int
Type is redundant.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/67466
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I23bf79a3e8918499f6c51e6ef829312d5872181a
Gerrit-Change-Number: 67466
Gerrit-PatchSet: 4
Gerrit-Owner: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Anil Kumar K
anil.kumar.k@intel.com
Gerrit-Reviewer: Bora Guvendik
bora.guvendik@intel.com
Gerrit-Reviewer: Cliff Huang
cliff.huang@intel.com
Gerrit-Reviewer: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Selma Bensaid
selma.bensaid@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@google.com
Gerrit-Reviewer: Zhixing Ma
zhixing.ma@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Zhixing Ma
zhixing.ma@intel.com
Gerrit-Attention: Anil Kumar K
anil.kumar.k@intel.com
Gerrit-Attention: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Attention: Selma Bensaid
selma.bensaid@intel.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@google.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@google.com
Gerrit-Comment-Date: Sun, 11 Sep 2022 10:41:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Nick Vaccaro
nvaccaro@google.com
Gerrit-MessageType: comment