[S] Change in coreboot[master]: util/ifittool: Fix buffer overflow with padded microcode patches - coreboot-gerrit

11 Sep 2022


      Attention is currently required from: Bora Guvendik, Zhixing Ma, Anil Kumar K, Jérémy Compostella, Selma Bensaid, Tim Wawrzynczak.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/67460 )
Change subject: util/ifittool: Fix buffer overflow with padded microcode patches
......................................................................
Patch Set 4: Code-Review+2
(1 comment)
Patchset:
PS4: 
Also fixes a segmentation fault when building coreboot for Broadwell (e.g. purism/librem_bdw) with CONFIG_CPU_INTEL_NUM_FIT_ENTRIES=16.
```
    UPDATE-FIT set FIT pointer to table
    UPDATE-FIT Microcode
make: *** [src/cpu/intel/fit/Makefile.inc:26: add_mcu_fit] Segmentation fault (core dumped)
```
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/67460
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id9c5fb6c1e264f3f5137d29201b9021c72d78fdd
Gerrit-Change-Number: 67460
Gerrit-PatchSet: 4
Gerrit-Owner: Jérémy Compostella jeremy.compostella@intel.com
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Anil Kumar K anil.kumar.k@intel.com
Gerrit-Reviewer: Bora Guvendik bora.guvendik@intel.com
Gerrit-Reviewer: Cliff Huang cliff.huang@intel.com
Gerrit-Reviewer: Jérémy Compostella jeremy.compostella@intel.com
Gerrit-Reviewer: Nick Vaccaro nvaccaro@google.com
Gerrit-Reviewer: Selma Bensaid selma.bensaid@intel.com
Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@google.com
Gerrit-Reviewer: Zhixing Ma zhixing.ma@intel.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Bora Guvendik bora.guvendik@intel.com
Gerrit-Attention: Zhixing Ma zhixing.ma@intel.com
Gerrit-Attention: Anil Kumar K anil.kumar.k@intel.com
Gerrit-Attention: Jérémy Compostella jeremy.compostella@intel.com
Gerrit-Attention: Selma Bensaid selma.bensaid@intel.com
Gerrit-Attention: Tim Wawrzynczak twawrzynczak@google.com
Gerrit-Comment-Date: Sun, 11 Sep 2022 10:43:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment