Change in coreboot[master]: spd.h: Move `DIMMx` macros to i440bx/raminit.h - coreboot-gerrit

3 Apr 2021


      Attention is currently required from: Nico Huber, Arthur Heymans, Michael Niewöhner, Patrick Rudolph.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52061 )
Change subject: spd.h: Move `DIMMx` macros to i440bx/raminit.h
......................................................................
Patch Set 2:
(1 comment)
File src/northbridge/intel/i440bx/raminit.h:
https://review.coreboot.org/c/coreboot/+/52061/comment/cb44b27d_70df40f8 
PS2, Line 9: /* DIMM SPD addresses */
           : #define DIMM0		0x50
           :
...
are dimm addresses common or controller/platform specific? if common, what about defining them at a  […]
They're mainboard-specific
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/52061
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie8d14849b4fb86d34a841d4a13ee3bbb46f9f71c
Gerrit-Change-Number: 52061
Gerrit-PatchSet: 2
Gerrit-Owner: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Michael Niewöhner foss@mniewoehner.de
Gerrit-Attention: Nico Huber nico.h@gmx.de
Gerrit-Attention: Arthur Heymans arthur@aheymans.xyz
Gerrit-Attention: Michael Niewöhner foss@mniewoehner.de
Gerrit-Attention: Patrick Rudolph siro@das-labor.org
Gerrit-Comment-Date: Sat, 03 Apr 2021 20:33:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Michael Niewöhner foss@mniewoehner.de
Gerrit-MessageType: comment