Change in ...coreboot[master]: soc/amd/common: Fix AmdLateRunApTask()

[Marshall Dawson (Code Review)]

Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/27277 )

Change subject: soc/amd/common: Fix AmdLateRunApTask()
......................................................................

Patch Set 4:

I'm not convinced yet that this is correct, although I agree with your premise.

The PI blob is built so that all callouts run through a function named AmdAgesaCallout().  This, in turn, calls a pointer with arguments Func, Data, ConfigPtr).  As a result, I believe the PI version of agesawrapper.c is written correctly to unwrap the information.

Unfortunately, I don't observe the function being run in agesawrapper.c, so it's not obvious whether there's a bug.  The stoney PI source doesn't call AmdLateRunApTask()