[XS] Change in coreboot[main]: vc/google/chromeos: Enable eSOL config with libgfx and uGOP - coreboot-gerrit

6 Aug 2024


      Attention is currently required from: Dinesh Gehlot, Jayvik Desai, Subrata Banik.
Angel Pons has posted comments on this change by Jayvik Desai. ( https://review.coreboot.org/c/coreboot/+/83705?usp=email )
Change subject: vc/google/chromeos: Enable eSOL config with libgfx and uGOP
......................................................................
Patch Set 13: Code-Review+1
(1 comment)
File src/vendorcode/google/chromeos/Kconfig:
https://review.coreboot.org/c/coreboot/+/83705/comment/d7a43cb8_0afc7cf3?usp... :
PS12, Line 106: def_bool y if FSP_UGOP_EARLY_SIGN_OF_LIFE || MAINBOARD_HAS_EARLY_LIBGFXINIT
              : 	def_bool n
...
I suggested setting the default directly using a boolean expression. Did this not work properly? […]
Done
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/83705?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ic8fe4ca5234de7f8e579f950f6ccbf750f4c7950
Gerrit-Change-Number: 83705
Gerrit-PatchSet: 13
Gerrit-Owner: Jayvik Desai jayvik@google.com
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Dinesh Gehlot digehlot@google.com
Gerrit-Reviewer: Subrata Banik subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Jayvik Desai jayvik@google.com
Gerrit-Attention: Subrata Banik subratabanik@google.com
Gerrit-Attention: Dinesh Gehlot digehlot@google.com
Gerrit-Comment-Date: Tue, 06 Aug 2024 09:42:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Angel Pons th3fanbus@gmail.com