Attention is currently required from: flora.fu@mediatek.com. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58794 )
Change subject: soc/mediatek/mt8195: add apusys init flow ......................................................................
Patch Set 3:
(5 comments)
Patchset:
PS3: It’d be great, if you sent a followup.
File src/soc/mediatek/mt8195/apusys.c:
https://review.coreboot.org/c/coreboot/+/58794/comment/d9cce33c_0218b015 PS2, Line 13: int i; `unsigned int` or `size_t`
https://review.coreboot.org/c/coreboot/+/58794/comment/364c0659_527071b8 PS2, Line 16: printk(BIOS_INFO, "APU_MBOX %p = %#x\n", Why is this level info?
https://review.coreboot.org/c/coreboot/+/58794/comment/a7c460df_e98f4497 PS2, Line 24: int i; Ditto.
https://review.coreboot.org/c/coreboot/+/58794/comment/a7e9aa7e_6c721082 PS2, Line 26: Setup Set up