Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38824 )
Change subject: soc/intel/apollolake: Display platform information
......................................................................
Patch Set 6:
(1 comment)
https://review.coreboot.org/c/coreboot/+/38824/6/src/soc/intel/apollolake/re...
File src/soc/intel/apollolake/report_platform.c:
https://review.coreboot.org/c/coreboot/+/38824/6/src/soc/intel/apollolake/re...
PS6, Line 106: aes_supported = (cpu_feature_flag & CPUID_AES) ? 1 : 0;
The value 0 or 1 is being used as an array index into mode[], so do not want to use boolean represen […]
Sorry, I did not check. Why not use the two strings `NOT supported` and `supported`, assign variables to it, and then do
"CPU: AES %s, TXT %s, VT %s\n, aes_supported ? a : b, txt_supported ? a : b, vt_supported ? a : b
`a` and `b` should be renamed.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/38824
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id4edfeae7faee9f5f80698cf34b31fdcb066a813
Gerrit-Change-Number: 38824
Gerrit-PatchSet: 6
Gerrit-Owner: Usha P
usha.p@intel.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Usha P
usha.p@intel.com
Gerrit-Reviewer: Werner Zeh
werner.zeh@siemens.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 19 Feb 2020 11:37:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Usha P
usha.p@intel.com
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-MessageType: comment