Change in coreboot[master]: soc/amd/picasso: remove PICASSO_ACPI_IO_BASE Kconfig option - coreboot-gerrit

4 Feb 2021


      Attention is currently required from: Jason Glenesk, Marshall Dawson, Felix Held.
Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50287 )
Change subject: soc/amd/picasso: remove PICASSO_ACPI_IO_BASE Kconfig option
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
File src/soc/amd/picasso/include/soc/iomap.h:
https://review.coreboot.org/c/coreboot/+/50287/comment/4ab0534f_433b96a1 
PS1, Line 75: PICASSO_
Just wondering why we have PICASSO in the name? Nothing else in this file is prefixed with the SoC name.
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/50287
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7ea62f1101ddefa8785da92de5ba2aaf7945694a
Gerrit-Change-Number: 50287
Gerrit-PatchSet: 1
Gerrit-Owner: Felix Held felix-coreboot@felixheld.de
Gerrit-Reviewer: Jason Glenesk jason.glenesk@gmail.com
Gerrit-Reviewer: Marshall Dawson marshalldawson3rd@gmail.com
Gerrit-Reviewer: Raul Rangel rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Jason Glenesk jason.glenesk@gmail.com
Gerrit-Attention: Marshall Dawson marshalldawson3rd@gmail.com
Gerrit-Attention: Felix Held felix-coreboot@felixheld.de
Gerrit-Comment-Date: Thu, 04 Feb 2021 20:52:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment