Attention is currently required from: Andrey Petrov, Arthur Heymans, Julius Werner, Nick Vaccaro, Subrata Banik, Yu-Ping Wu.
Hello Andrey Petrov, Arthur Heymans, Julius Werner, Nick Vaccaro, Yu-Ping Wu, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/77796?usp=email
to look at the new patch set (#3).
The following approvals got outdated and were removed: Verified+1 by build bot (Jenkins)
Change subject: {commonlib, libpayload}: Add "is_external display" in coreboot table ......................................................................
{commonlib, libpayload}: Add "is_external display" in coreboot table
This patch introduces a new coreboot table entry named "is_external_display" to understand if external display is attached.
This information is useful to prevent graceful shutdown by payload when the LID is closed but an external display is present.
This piece of the information will be gathered by coreboot and passed into the payload using this new entry aka external_display because payload (i.e., deptcharge) doesn't have any other way to determine if external display is available.
BUG=b:299137940 TEST=Able to build and boot google/rex.
w/o this patch:
LID closed and external display attached (HDMI) in developer mode (GBB 0x39):
System is powered off by depthcharge
w/ this patch:
LID closed and external display attached (HDMI) in developer mode (GBB 0x39):
Booted to OS and device is alive/usable
Change-Id: I0fa7eee4c5a50371a7a66c6ca1ac2c7d046d010b Signed-off-by: Subrata Banik subratabanik@google.com --- M payloads/libpayload/include/coreboot_tables.h M src/commonlib/include/commonlib/coreboot_tables.h M src/drivers/intel/fsp2_0/Kconfig M src/drivers/intel/fsp2_0/graphics.c M src/drivers/intel/fsp2_0/include/fsp/graphics.h 5 files changed, 48 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/96/77796/3