Subrata Banik has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/33783
Change subject: device/oprom: Fix coding standard problem from // to /* */ ......................................................................
device/oprom: Fix coding standard problem from // to /* */
Change-Id: I321d9e54fee42cd9f0cff5f962246934209577f7 Signed-off-by: Subrata Banik subrata.banik@intel.com --- M src/device/oprom/realmode/x86.c 1 file changed, 17 insertions(+), 15 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/83/33783/1
diff --git a/src/device/oprom/realmode/x86.c b/src/device/oprom/realmode/x86.c index a7631a1..80455a5 100644 --- a/src/device/oprom/realmode/x86.c +++ b/src/device/oprom/realmode/x86.c @@ -104,9 +104,9 @@
printk(BIOS_INFO, "Oops, exception %d while executing option rom\n", regs->vector); - x86_exception(regs); // Call coreboot exception handler + x86_exception(regs); /* Call coreboot exception handler */
- return 0; // Never really returns + return 0; /* Never really returns */ }
static int intXX_unknown_handler(void) @@ -238,9 +238,9 @@ static u8 vbe_set_mode(vbe_mode_info_t * mi) { printk(BIOS_DEBUG, "VBE: Setting VESA mode %04x\n", mi->video_mode); - // request linear framebuffer mode + /* request linear framebuffer mode */ mi->video_mode |= (1 << 14); - // request clearing of framebuffer + /* request clearing of framebuffer */ mi->video_mode &= ~(1 << 15); realmode_interrupt(0x10, VESA_SET_MODE, mi->video_mode, 0x0000, 0x0000, 0x0000, 0x0000); @@ -393,8 +393,9 @@ ip, cs, flags); #endif
- // Fetch arguments from the stack and put them to a place - // suitable for the interrupt handlers + /* Fetch arguments from the stack and put them to a place + * suitable for the interrupt handlers + */ X86_EAX = eax; X86_ECX = ecx; X86_EDX = edx; @@ -409,15 +410,16 @@ X86_CS = cs; X86_EFLAGS = flags;
- // Call the interrupt handler for this int# + /* Call the interrupt handler for this int# */ ret = intXX_handler[intnumber]();
- // Put registers back on the stack. The assembler code - // will later pop them. - // What happens here is that we force (volatile!) changing - // the values of the parameters of this function. We do this - // because we know that they stay alive on the stack after - // we leave this function. Don't say this is bollocks. + /* Put registers back on the stack. The assembler code + * will later pop them. + * What happens here is that we force (volatile!) changing + * the values of the parameters of this function. We do this + * because we know that they stay alive on the stack after + * we leave this function. Don't say this is bollocks. + */ *(volatile u32 *)&eax = X86_EAX; *(volatile u32 *)&ecx = X86_ECX; *(volatile u32 *)&edx = X86_EDX; @@ -428,10 +430,10 @@
/* Pass success or error back to our caller via the CARRY flag */ if (ret) { - flags &= ~1; // no error: clear carry + flags &= ~1; /* no error: clear carry */ }else{ printk(BIOS_DEBUG,"int%02x call returned error.\n", intnumber); - flags |= 1; // error: set carry + flags |= 1; /* error: set carry */ } *(volatile u16 *)&stackflags = flags;
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33783 )
Change subject: device/oprom: Fix coding standard problem from // to /* */ ......................................................................
Patch Set 1: Code-Review+1
Hello Arthur Heymans, Paul Menzel, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/33783
to look at the new patch set (#2).
Change subject: device/oprom/realmode/x86: Fix coding standard problem from // to /* */ ......................................................................
device/oprom/realmode/x86: Fix coding standard problem from // to /* */
Change-Id: I321d9e54fee42cd9f0cff5f962246934209577f7 Signed-off-by: Subrata Banik subrata.banik@intel.com --- M src/device/oprom/realmode/x86.c 1 file changed, 17 insertions(+), 15 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/83/33783/2
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33783 )
Change subject: device/oprom/realmode/x86: Fix coding standard problem from // to /* */ ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/#/c/33783/2/src/device/oprom/realmode/x86.c File src/device/oprom/realmode/x86.c:
https://review.coreboot.org/#/c/33783/2/src/device/oprom/realmode/x86.c@396 PS2, Line 396: /* Fetch arguments from the stack and put them to a place : * suitable for the interrupt handlers : */ Thanks, but please use one of the styles listed on the coding style.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33783 )
Change subject: device/oprom/realmode/x86: Fix coding standard problem from // to /* */ ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/#/c/33783/2/src/device/oprom/realmode/x86.c File src/device/oprom/realmode/x86.c:
https://review.coreboot.org/#/c/33783/2/src/device/oprom/realmode/x86.c@396 PS2, Line 396: /* Fetch arguments from the stack and put them to a place : * suitable for the interrupt handlers : */
Thanks, but please use one of the styles listed on the coding style.
Done
Hello Kyösti Mälkki, Aaron Durbin, Arthur Heymans, Paul Menzel, build bot (Jenkins), Nico Huber, Furquan Shaikh,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/33783
to look at the new patch set (#3).
Change subject: device/oprom/realmode/x86: Fix coding standard problem from // to /* */ ......................................................................
device/oprom/realmode/x86: Fix coding standard problem from // to /* */
Change-Id: I321d9e54fee42cd9f0cff5f962246934209577f7 Signed-off-by: Subrata Banik subrata.banik@intel.com --- M src/device/oprom/realmode/x86.c 1 file changed, 41 insertions(+), 28 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/83/33783/3
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33783 )
Change subject: device/oprom/realmode/x86: Fix coding standard problem from // to /* */ ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/#/c/33783/3/src/device/oprom/realmode/x86.c File src/device/oprom/realmode/x86.c:
https://review.coreboot.org/#/c/33783/3/src/device/oprom/realmode/x86.c@99 PS3, Line 99: .error_code=0, /* FIXME: fill in */ spaces required around that '=' (ctx:VxV)
Hello Kyösti Mälkki, Aaron Durbin, Arthur Heymans, Paul Menzel, build bot (Jenkins), Nico Huber, Furquan Shaikh,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/33783
to look at the new patch set (#4).
Change subject: device/oprom/realmode/x86: Fix coding standard problem from // to /* */ ......................................................................
device/oprom/realmode/x86: Fix coding standard problem from // to /* */
Change-Id: I321d9e54fee42cd9f0cff5f962246934209577f7 Signed-off-by: Subrata Banik subrata.banik@intel.com --- M src/device/oprom/realmode/x86.c 1 file changed, 42 insertions(+), 28 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/83/33783/4
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33783 )
Change subject: device/oprom/realmode/x86: Fix coding standard problem from // to /* */ ......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/#/c/33783/4/src/device/oprom/realmode/x86.c File src/device/oprom/realmode/x86.c:
https://review.coreboot.org/#/c/33783/4/src/device/oprom/realmode/x86.c@100 PS4, Line 100: .error_code=0, spaces required around that '=' (ctx:VxV)
Hello Kyösti Mälkki, Aaron Durbin, Arthur Heymans, Paul Menzel, build bot (Jenkins), Nico Huber, Furquan Shaikh,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/33783
to look at the new patch set (#5).
Change subject: device/oprom/realmode/x86: Fix coding standard problem from // to /* */ ......................................................................
device/oprom/realmode/x86: Fix coding standard problem from // to /* */
Change-Id: I321d9e54fee42cd9f0cff5f962246934209577f7 Signed-off-by: Subrata Banik subrata.banik@intel.com --- M src/device/oprom/realmode/x86.c 1 file changed, 53 insertions(+), 40 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/83/33783/5
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33783 )
Change subject: device/oprom/realmode/x86: Fix coding standard problem from // to /* */ ......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/#/c/33783/4/src/device/oprom/realmode/x86.c File src/device/oprom/realmode/x86.c:
https://review.coreboot.org/#/c/33783/4/src/device/oprom/realmode/x86.c@100 PS4, Line 100: .error_code=0,
spaces required around that '=' (ctx:VxV)
Done
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33783 )
Change subject: device/oprom/realmode/x86: Fix coding standard problem from // to /* */ ......................................................................
Patch Set 5:
(1 comment)
not sure if we'll switch to clang format.
https://review.coreboot.org/#/c/33783/5/src/device/oprom/realmode/x86.c File src/device/oprom/realmode/x86.c:
https://review.coreboot.org/#/c/33783/5/src/device/oprom/realmode/x86.c@89 PS5, Line 89: struct eregs reg_info = { : .eax = X86_EAX, : .ecx = X86_ECX, : .edx = X86_EDX, : .ebx = X86_EBX, : .esp = X86_ESP, : .ebp = X86_EBP, : .esi = X86_ESI, : .edi = X86_EDI, : .vector = M.x86.intno, : .error_code = 0, /* FIXME: fill in */ : .eip = X86_EIP, : .cs = X86_CS, : .eflags = X86_EFLAGS : }; if we use clang-format, this will be: struct eregs reg_info = { .eax = X86_EAX, .ecx = X86_ECX, .edx = X86_EDX, .ebx = X86_EBX, .esp = X86_ESP, .ebp = X86_EBP, .esi = X86_ESI, .edi = X86_EDI, .vector = M.x86.intno, .error_code = 0, // FIXME: fill in .eip = X86_EIP, .cs = X86_CS, .eflags = X86_EFLAGS };
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33783 )
Change subject: device/oprom/realmode/x86: Fix coding standard problem from // to /* */ ......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/#/c/33783/5/src/device/oprom/realmode/x86.c File src/device/oprom/realmode/x86.c:
https://review.coreboot.org/#/c/33783/5/src/device/oprom/realmode/x86.c@89 PS5, Line 89: struct eregs reg_info = { : .eax = X86_EAX, : .ecx = X86_ECX, : .edx = X86_EDX, : .ebx = X86_EBX, : .esp = X86_ESP, : .ebp = X86_EBP, : .esi = X86_ESI, : .edi = X86_EDI, : .vector = M.x86.intno, : .error_code = 0, /* FIXME: fill in */ : .eip = X86_EIP, : .cs = X86_CS, : .eflags = X86_EFLAGS : };
if we use clang-format, this will be: […]
are you recommending me to make it clang-format for this ?
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33783 )
Change subject: device/oprom/realmode/x86: Fix coding standard problem from // to /* */ ......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/#/c/33783/5/src/device/oprom/realmode/x86.c File src/device/oprom/realmode/x86.c:
https://review.coreboot.org/#/c/33783/5/src/device/oprom/realmode/x86.c@89 PS5, Line 89: struct eregs reg_info = { : .eax = X86_EAX, : .ecx = X86_ECX, : .edx = X86_EDX, : .ebx = X86_EBX, : .esp = X86_ESP, : .ebp = X86_EBP, : .esi = X86_ESI, : .edi = X86_EDI, : .vector = M.x86.intno, : .error_code = 0, /* FIXME: fill in */ : .eip = X86_EIP, : .cs = X86_CS, : .eflags = X86_EFLAGS : };
are you recommending me to make it clang-format for this ?
I don't know if https://review.coreboot.org/c/coreboot/+/33405 recommend us to use clang-format or not.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33783 )
Change subject: device/oprom/realmode/x86: Fix coding standard problem from // to /* */ ......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/#/c/33783/5/src/device/oprom/realmode/x86.c File src/device/oprom/realmode/x86.c:
https://review.coreboot.org/#/c/33783/5/src/device/oprom/realmode/x86.c@89 PS5, Line 89: struct eregs reg_info = { : .eax = X86_EAX, : .ecx = X86_ECX, : .edx = X86_EDX, : .ebx = X86_EBX, : .esp = X86_ESP, : .ebp = X86_EBP, : .esi = X86_ESI, : .edi = X86_EDI, : .vector = M.x86.intno, : .error_code = 0, /* FIXME: fill in */ : .eip = X86_EIP, : .cs = X86_CS, : .eflags = X86_EFLAGS : };
I don't know if https://review.coreboot. […]
I guess this is one of those examples, why we don't use clang-format yet. What clang-format does, looks wrong to me at least.
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33783 )
Change subject: device/oprom/realmode/x86: Fix coding standard problem from // to /* */ ......................................................................
Patch Set 5: Code-Review+1
ron minnich has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33783 )
Change subject: device/oprom/realmode/x86: Fix coding standard problem from // to /* */ ......................................................................
Patch Set 5: Code-Review-1
// is allowed by our coding standards since 2012. I don't see a need for much of this change. I accept that I may be wrong here :-)
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33783 )
Change subject: device/oprom/realmode/x86: Fix coding standard problem from // to /* */ ......................................................................
Patch Set 5:
Patch Set 5: Code-Review-1
// is allowed by our coding standards since 2012. I don't see a need for much of this change. I accept that I may be wrong here :-)
I was referring this "Commenting" section
https://www.coreboot.org/Coding_Style
as you said, i can abandon this CL, its not big deal. But i need help to review other CL's in this topic.
Subrata Banik has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/33783 )
Change subject: device/oprom/realmode/x86: Fix coding standard problem from // to /* */ ......................................................................
Abandoned