HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33783 )
Change subject: device/oprom/realmode/x86: Fix coding standard problem from // to /* */ ......................................................................
Patch Set 5:
(1 comment)
not sure if we'll switch to clang format.
https://review.coreboot.org/#/c/33783/5/src/device/oprom/realmode/x86.c File src/device/oprom/realmode/x86.c:
https://review.coreboot.org/#/c/33783/5/src/device/oprom/realmode/x86.c@89 PS5, Line 89: struct eregs reg_info = { : .eax = X86_EAX, : .ecx = X86_ECX, : .edx = X86_EDX, : .ebx = X86_EBX, : .esp = X86_ESP, : .ebp = X86_EBP, : .esi = X86_ESI, : .edi = X86_EDI, : .vector = M.x86.intno, : .error_code = 0, /* FIXME: fill in */ : .eip = X86_EIP, : .cs = X86_CS, : .eflags = X86_EFLAGS : }; if we use clang-format, this will be: struct eregs reg_info = { .eax = X86_EAX, .ecx = X86_ECX, .edx = X86_EDX, .ebx = X86_EBX, .esp = X86_ESP, .ebp = X86_EBP, .esi = X86_ESI, .edi = X86_EDI, .vector = M.x86.intno, .error_code = 0, // FIXME: fill in .eip = X86_EIP, .cs = X86_CS, .eflags = X86_EFLAGS };