HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/43946 )
Change subject: src/security: Add missing <{stddef,stdint}|types> ......................................................................
src/security: Add missing <{stddef,stdint}|types>
Change-Id: If22d582891f869b04fee79983658ba5c5467d261 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/security/intel/stm/SmmStm.c M src/security/memory/memory_clear.c M src/security/tpm/tspi.h M src/security/tpm/tspi/crtm.c M src/security/tpm/tspi/log.c M src/security/tpm/tspi/tspi.c M src/security/tpm/tss/tcg-1.2/tss.c M src/security/tpm/tss/tcg-2.0/tss.c M src/security/tpm/tss/tcg-2.0/tss_marshaling.c M src/security/vboot/common.c M src/security/vboot/ec_sync.c M src/security/vboot/mrc_cache_hash_tpm.c M src/security/vboot/secdata_tpm.c M src/security/vboot/vboot_common.h M src/security/vboot/vboot_logic.c 15 files changed, 24 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/46/43946/1
diff --git a/src/security/intel/stm/SmmStm.c b/src/security/intel/stm/SmmStm.c index 7256401..07496e8 100644 --- a/src/security/intel/stm/SmmStm.c +++ b/src/security/intel/stm/SmmStm.c @@ -6,8 +6,8 @@ #include <cpu/x86/msr.h> #include <cpu/x86/cache.h> #include <security/intel/stm/SmmStm.h> -#include <stdbool.h> #include <string.h> +#include <types.h>
#define TXT_EVTYPE_BASE 0x400 #define TXT_EVTYPE_STM_HASH (TXT_EVTYPE_BASE + 14) diff --git a/src/security/memory/memory_clear.c b/src/security/memory/memory_clear.c index 557125d..3f8db2f 100644 --- a/src/security/memory/memory_clear.c +++ b/src/security/memory/memory_clear.c @@ -20,6 +20,8 @@ #include <security/memory/memory.h> #include <cbmem.h> #include <acpi/acpi.h> +#include <stddef.h> +#include <stdint.h>
/* Helper to find free space for memset_pae. */ static uintptr_t get_free_memory_range(struct memranges *mem, diff --git a/src/security/tpm/tspi.h b/src/security/tpm/tspi.h index a776a4d..92adaee 100644 --- a/src/security/tpm/tspi.h +++ b/src/security/tpm/tspi.h @@ -6,6 +6,8 @@ #include <security/tpm/tss.h> #include <commonlib/tcpa_log_serialized.h> #include <commonlib/region.h> +#include <stddef.h> +#include <stdint.h> #include <vb2_api.h>
#define TPM_PCR_MAX_LEN 64 diff --git a/src/security/tpm/tspi/crtm.c b/src/security/tpm/tspi/crtm.c index f5c788c..463b07a 100644 --- a/src/security/tpm/tspi/crtm.c +++ b/src/security/tpm/tspi/crtm.c @@ -5,6 +5,7 @@ #include <cbfs.h> #include "crtm.h" #include <string.h> +#include <types.h>
/* * This function sets the TCPA log namespace diff --git a/src/security/tpm/tspi/log.c b/src/security/tpm/tspi/log.c index 1d6f9ac..948648a 100644 --- a/src/security/tpm/tspi/log.c +++ b/src/security/tpm/tspi/log.c @@ -7,6 +7,8 @@ #include <symbols.h> #include <cbmem.h> #include <bootstate.h> +#include <stddef.h> +#include <stdint.h> #include <vb2_sha.h>
static struct tcpa_table *tcpa_cbmem_init(void) diff --git a/src/security/tpm/tspi/tspi.c b/src/security/tpm/tspi/tspi.c index 6ef0138..06eab0b 100644 --- a/src/security/tpm/tspi/tspi.c +++ b/src/security/tpm/tspi/tspi.c @@ -7,6 +7,8 @@ #include <security/tpm/tss.h> #include <assert.h> #include <security/vboot/misc.h> +#include <stddef.h> +#include <stdint.h> #include <vb2_api.h> #include <vb2_sha.h>
diff --git a/src/security/tpm/tss/tcg-1.2/tss.c b/src/security/tpm/tss/tcg-1.2/tss.c index 30cd1cc..07e1b36 100644 --- a/src/security/tpm/tss/tcg-1.2/tss.c +++ b/src/security/tpm/tss/tcg-1.2/tss.c @@ -17,6 +17,8 @@ #include <security/tpm/tis.h> #include <vb2_api.h> #include <security/tpm/tss.h> +#include <stddef.h> +#include <stdint.h>
#include "tss_internal.h" #include "tss_commands.h" diff --git a/src/security/tpm/tss/tcg-2.0/tss.c b/src/security/tpm/tss/tcg-2.0/tss.c index 79d8eb9..95649a7 100644 --- a/src/security/tpm/tss/tcg-2.0/tss.c +++ b/src/security/tpm/tss/tcg-2.0/tss.c @@ -6,6 +6,7 @@ #include <vb2_api.h> #include <security/tpm/tis.h> #include <security/tpm/tss.h> +#include <types.h>
#include "tss_structures.h" #include "tss_marshaling.h" diff --git a/src/security/tpm/tss/tcg-2.0/tss_marshaling.c b/src/security/tpm/tss/tcg-2.0/tss_marshaling.c index f31c7d0..a93a397 100644 --- a/src/security/tpm/tss/tcg-2.0/tss_marshaling.c +++ b/src/security/tpm/tss/tcg-2.0/tss_marshaling.c @@ -2,6 +2,8 @@
#include <commonlib/iobuf.h> #include <console/console.h> +#include <stddef.h> +#include <stdint.h> #include <string.h>
#include "tss_marshaling.h" diff --git a/src/security/vboot/common.c b/src/security/vboot/common.c index 0121f56..8354727 100644 --- a/src/security/vboot/common.c +++ b/src/security/vboot/common.c @@ -8,6 +8,7 @@ #include <security/vboot/misc.h> #include <security/vboot/symbols.h> #include <security/vboot/vboot_common.h> +#include <stddef.h>
static struct vb2_context *vboot_ctx;
diff --git a/src/security/vboot/ec_sync.c b/src/security/vboot/ec_sync.c index 97b8ed9..33d7b97 100644 --- a/src/security/vboot/ec_sync.c +++ b/src/security/vboot/ec_sync.c @@ -11,6 +11,7 @@ #include <security/vboot/vboot_common.h> #include <timer.h> #include <timestamp.h> +#include <types.h> #include <vb2_api.h> #include <vboot_api.h> /* for VbExDisplayScreen() and VbScreenData */
diff --git a/src/security/vboot/mrc_cache_hash_tpm.c b/src/security/vboot/mrc_cache_hash_tpm.c index bc500a2..c993fb0 100644 --- a/src/security/vboot/mrc_cache_hash_tpm.c +++ b/src/security/vboot/mrc_cache_hash_tpm.c @@ -7,6 +7,8 @@ #include <security/tpm/tss.h> #include <fsp/memory_init.h> #include <console/console.h> +#include <stddef.h> +#include <stdint.h> #include <string.h>
void mrc_cache_update_hash(const uint8_t *data, size_t size) diff --git a/src/security/vboot/secdata_tpm.c b/src/security/vboot/secdata_tpm.c index 691d2c0..1a40e4f 100644 --- a/src/security/vboot/secdata_tpm.c +++ b/src/security/vboot/secdata_tpm.c @@ -10,6 +10,8 @@ #include <security/tpm/tspi.h> #include <security/tpm/tss.h> #include <security/tpm/tss/tcg-1.2/tss_structures.h> +#include <stddef.h> +#include <stdint.h> #include <vb2_api.h> #include <console/console.h>
diff --git a/src/security/vboot/vboot_common.h b/src/security/vboot/vboot_common.h index f2cff65..e616e91 100644 --- a/src/security/vboot/vboot_common.h +++ b/src/security/vboot/vboot_common.h @@ -3,6 +3,7 @@ #define __VBOOT_VBOOT_COMMON_H__
#include <commonlib/region.h> +#include <stddef.h> #include <vb2_api.h>
/* diff --git a/src/security/vboot/vboot_logic.c b/src/security/vboot/vboot_logic.c index c4c3b4b..bf6b0cf 100644 --- a/src/security/vboot/vboot_logic.c +++ b/src/security/vboot/vboot_logic.c @@ -9,6 +9,8 @@ #include <security/vboot/misc.h> #include <security/vboot/vbnv.h> #include <security/vboot/tpm_common.h> +#include <stddef.h> +#include <stdint.h> #include <string.h> #include <timestamp.h> #include <vb2_api.h>
Hello build bot (Jenkins), Aaron Durbin,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/43946
to look at the new patch set (#2).
Change subject: src/security: Add missing <{stddef,stdint}|types> ......................................................................
src/security: Add missing <{stddef,stdint}|types>
Include <types.h> when stddef, stdint and stdbool are needed.
Change-Id: If22d582891f869b04fee79983658ba5c5467d261 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/security/intel/stm/SmmStm.c M src/security/memory/memory_clear.c M src/security/tpm/tspi.h M src/security/tpm/tspi/crtm.c M src/security/tpm/tspi/log.c M src/security/tpm/tspi/tspi.c M src/security/tpm/tss/tcg-1.2/tss.c M src/security/tpm/tss/tcg-2.0/tss.c M src/security/tpm/tss/tcg-2.0/tss_marshaling.c M src/security/vboot/common.c M src/security/vboot/ec_sync.c M src/security/vboot/mrc_cache_hash_tpm.c M src/security/vboot/secdata_tpm.c M src/security/vboot/vboot_common.h M src/security/vboot/vboot_logic.c 15 files changed, 24 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/46/43946/2
HAOUAS Elyes has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/43946 )
Change subject: src/security: Add missing <{stddef,stdint}|types> ......................................................................
Abandoned
-
HAOUAS Elyes (Code Review)