Attention is currently required from: Ariel Fang.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59182 )
Change subject: mb/google/brya/var/primus: Update thermal table for primus
......................................................................
Patch Set 8:
(1 comment)
File src/mainboard/google/brya/variants/primus/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/59182/comment/d525d692_5001403d
PS8, Line 79: [0] = DPTF_PASSIVE(CPU, CPU, 95, 5000),
: [1] = DPTF_PASSIVE(CPU, TEMP_SENSOR_0, 90, 5000),
: [2] = DPTF_PASSIVE(CHARGER, TEMP_SENSOR_1, 90, 5000),
: [3] = DPTF_PASSIVE(CPU, TEMP_SENSOR_2, 90, 5000),
: [4] = DPTF_PASSIVE(CPU, TEMP_SENSOR_3, 90, 5000),
can you line up each column?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/59182
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id4d8dbe678b7f0870aeffa0a0118e65de9d5c22d
Gerrit-Change-Number: 59182
Gerrit-PatchSet: 8
Gerrit-Owner: Ariel Fang
ariel_fang@wistron.corp-partner.google.com
Gerrit-Reviewer: Ariel Fang
ariel_fang@wistron.corp-partner.google.com
Gerrit-Reviewer: Sumeet R Pawnikar
sumeet.r.pawnikar@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Casper Chang
casper_chang@wistron.corp-partner.google.com
Gerrit-CC: Malik Hsu
malik_hsu@wistron.corp-partner.google.com
Gerrit-CC: Mark Hsieh
mark_hsieh@wistron.corp-partner.google.com
Gerrit-CC: Scott Chao
scott_chao@wistron.corp-partner.google.com
Gerrit-CC: Terry Chen
terry_chen@wistron.corp-partner.google.com
Gerrit-Attention: Ariel Fang
ariel_fang@wistron.corp-partner.google.com
Gerrit-Comment-Date: Tue, 23 Nov 2021 16:25:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment