Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34450 )
Change subject: string: implement strspn, strcspn, atol
......................................................................
Patch Set 7:
(2 comments)
https://review.coreboot.org/c/coreboot/+/34450/7/src/lib/string.c
File src/lib/string.c:
https://review.coreboot.org/c/coreboot/+/34450/7/src/lib/string.c@168
PS7, Line 168: long ret = 0;
: long sign = 1;
Nit: These two variables could be the same
Done
https://review.coreboot.org/c/coreboot/+/34450/7/src/lib/string.c@171
PS7, Line 171: str += strspn(str, " \t");
nit: if we want to be very pendantic this should be all that isspace() is true for, so " \t\n\r\f\v"
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34450
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id8fa880357124b620bde8884949bd8ffff7d0762
Gerrit-Change-Number: 34450
Gerrit-PatchSet: 7
Gerrit-Owner: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Nitheesh Sekar
nsekar@codeaurora.org
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Yuji Sasaki
sasakiy@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Thu, 08 Aug 2019 19:36:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Gerrit-MessageType: comment