Attention is currently required from: Lance Zhao, Nico Huber, David Hendricks, Tim Wawrzynczak, Eric Lai, Elyes Haouas.
David Hendricks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68593 )
Change subject: acpi/Kconfig: Remove unused ACPI_EINJ config option
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2:
Just to make sure we're on the same page: Did anyone see a `CONFIG_ACPI_EINJ`, […]
Yes, it's used in silicon vendors' development repos which are used by various other companies who are working on coreboot for server platforms.
Moving the Kconfig variable somewhere else downstream will only require a little bit of extra effort. IMO it's more valuable to have people work with upstream as much as possible rather than push them to diverge further away.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/68593
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I222478572a9e5efadd6719a164558833298e4c99
Gerrit-Change-Number: 68593
Gerrit-PatchSet: 2
Gerrit-Owner: Elyes Haouas
ehaouas@noos.fr
Gerrit-Reviewer: Elyes Haouas
ehaouas@noos.fr
Gerrit-Reviewer: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: Lance Zhao
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Tim Wawrzynczak
inforichland@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: David Hendricks
Gerrit-CC: David Hendricks
david.hendricks@gmail.com
Gerrit-CC: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-CC: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-CC: Shuming Chu (Shuming)
s1218944@gmail.com
Gerrit-Attention: Lance Zhao
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: David Hendricks
david.hendricks@gmail.com
Gerrit-Attention: Tim Wawrzynczak
inforichland@gmail.com
Gerrit-Attention: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Attention: Elyes Haouas
ehaouas@noos.fr
Gerrit-Comment-Date: Sat, 19 Nov 2022 00:00:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Comment-In-Reply-To: David Hendricks
david.hendricks@gmail.com
Gerrit-MessageType: comment