Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29917 )
Change subject: src: Remove unused variables ......................................................................
Patch Set 31:
(2 comments)
https://review.coreboot.org/#/c/29917/31/src/cpu/amd/quadcore/quadcore.c File src/cpu/amd/quadcore/quadcore.c:
https://review.coreboot.org/#/c/29917/31/src/cpu/amd/quadcore/quadcore.c@101 PS31, Line 101: get_boot_apic_id(nodeid This looks strange. It adds an unused variable.
https://review.coreboot.org/#/c/29917/31/src/soc/cavium/common/bootblock.c File src/soc/cavium/common/bootblock.c:
https://review.coreboot.org/#/c/29917/31/src/soc/cavium/common/bootblock.c@4... PS31, Line 41: CONFIG_COLLECT_TIMESTAMPS Drop the CONFIG_