Yu-Ping Wu has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/35142 )
Change subject: mediatek/mt8183: Remove unnecessary parentheses ......................................................................
mediatek/mt8183: Remove unnecessary parentheses
Parentheses are unnecessary for conditions like '(a == b) || (c == d)'. Extra spaces are also removed.
Change-Id: I0c554bf1577b40286f7a51a8fc5804bdbb7c8bd1 Signed-off-by: Yu-Ping Wu yupingso@google.com --- M src/soc/mediatek/mt8183/dramc_pi_basic_api.c M src/soc/mediatek/mt8183/dramc_pi_calibration_api.c M src/soc/mediatek/mt8183/rtc.c 3 files changed, 7 insertions(+), 7 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/42/35142/1
diff --git a/src/soc/mediatek/mt8183/dramc_pi_basic_api.c b/src/soc/mediatek/mt8183/dramc_pi_basic_api.c index cdba2af..cb462e9 100644 --- a/src/soc/mediatek/mt8183/dramc_pi_basic_api.c +++ b/src/soc/mediatek/mt8183/dramc_pi_basic_api.c @@ -63,7 +63,7 @@ (sw_impedance[dq_term][0] << 5) | (sw_impedance[dq_term][1] << 0)); clrsetbits_le32(&ch[0].ao.shu[0].drving[1], - (0x1f << 25)|(0x1f << 20) | (1 << 31), + (0x1f << 25) | (0x1f << 20) | (1 << 31), (sw_impedance[dq_term][0] << 25) | (sw_impedance[dq_term][1] << 20) | (!dq_term << 31)); clrsetbits_le32(&ch[0].ao.shu[0].drving[2], (0x1f << 5) | (0x1f << 0), diff --git a/src/soc/mediatek/mt8183/dramc_pi_calibration_api.c b/src/soc/mediatek/mt8183/dramc_pi_calibration_api.c index 05f793e..e8ee818 100644 --- a/src/soc/mediatek/mt8183/dramc_pi_calibration_api.c +++ b/src/soc/mediatek/mt8183/dramc_pi_calibration_api.c @@ -1378,7 +1378,7 @@
static void dramc_set_dqdqs_dly(u8 chn, u8 rank, enum CAL_TYPE type, s32 dly) { - if ((type == RX_WIN_RD_DQC) || (type == RX_WIN_TEST_ENG)) + if (type == RX_WIN_RD_DQC || type == RX_WIN_TEST_ENG) dramc_set_rx_dly(chn, rank, dly); else dramc_set_tx_dly_factor(chn, rank, type, dly); @@ -1553,7 +1553,7 @@ dramc_dbg("[channel %d] [rank %d] type:%d, vref_enable:%d\n", chn, rank, type, vref_scan_enable);
- if ((type == TX_WIN_DQ_ONLY) || (type == TX_WIN_DQ_DQM)) { + if (type == TX_WIN_DQ_ONLY || type == TX_WIN_DQ_DQM) { for (size_t i = 0; i < 2; i++) { write32(&ch[chn].phy.shu[0].rk[rank].b[i].dq[0], 0); clrbits_le32(&ch[chn].phy.shu[0].rk[rank].b[i].dq[1], @@ -1592,7 +1592,7 @@ if (vref_scan_enable) dramc_set_vref(chn, rank, type, vref_dly.vref);
- if ((type == RX_WIN_RD_DQC) || (type == RX_WIN_TEST_ENG)) { + if (type == RX_WIN_RD_DQC || type == RX_WIN_TEST_ENG) { dramc_set_rx_dly_factor(chn, rank, RX_DQM, FIRST_DQ_DELAY); dramc_set_rx_dly_factor(chn, rank, @@ -1666,7 +1666,7 @@ if (vref_scan_enable) dramc_set_vref(chn, rank, type, vref_dly.vref);
- if ((type == RX_WIN_RD_DQC) || (type == RX_WIN_TEST_ENG)) + if (type == RX_WIN_RD_DQC || type == RX_WIN_TEST_ENG) dramc_set_rx_best_dly(chn, rank, vref_dly.perbit_dly); else dramc_set_tx_best_dly(chn, rank, vref_dly.perbit_dly, diff --git a/src/soc/mediatek/mt8183/rtc.c b/src/soc/mediatek/mt8183/rtc.c index af30d1f..f8d81f8 100644 --- a/src/soc/mediatek/mt8183/rtc.c +++ b/src/soc/mediatek/mt8183/rtc.c @@ -177,7 +177,7 @@ /* select 26M as target clock */ val = rtc_get_frequency_meter(middle, PMIC_FQMTR_CON0_FQM26M_CK, 0);
- if ((val >= RTC_FQMTR_LOW_BASE) && (val <= RTC_FQMTR_HIGH_BASE)) + if (val >= RTC_FQMTR_LOW_BASE && val <= RTC_FQMTR_HIGH_BASE) break; if (val > RTC_FQMTR_HIGH_BASE) right = middle; @@ -185,7 +185,7 @@ left = middle; }
- if ((val >= RTC_FQMTR_LOW_BASE) && (val <= RTC_FQMTR_HIGH_BASE)) + if (val >= RTC_FQMTR_LOW_BASE && val <= RTC_FQMTR_HIGH_BASE) return middle;
val = rtc_get_frequency_meter(left, PMIC_FQMTR_CON0_FQM26M_CK, 0);
Hello Julius Werner, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/35142
to look at the new patch set (#2).
Change subject: mediatek/mt8183: Remove unnecessary parentheses ......................................................................
mediatek/mt8183: Remove unnecessary parentheses
Parentheses are unnecessary for conditions like '(a == b) || (c == d)'.
Change-Id: I0c554bf1577b40286f7a51a8fc5804bdbb7c8bd1 Signed-off-by: Yu-Ping Wu yupingso@google.com --- M src/soc/mediatek/mt8183/dramc_pi_basic_api.c M src/soc/mediatek/mt8183/dramc_pi_calibration_api.c M src/soc/mediatek/mt8183/rtc.c 3 files changed, 7 insertions(+), 7 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/42/35142/2
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35142 )
Change subject: mediatek/mt8183: Remove unnecessary parentheses ......................................................................
Patch Set 2: Code-Review+2
Thank you!
Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35142 )
Change subject: mediatek/mt8183: Remove unnecessary parentheses ......................................................................
Patch Set 3: Code-Review+2
Huayang Duan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35142 )
Change subject: mediatek/mt8183: Remove unnecessary parentheses ......................................................................
Patch Set 3: Code-Review+2
Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/35142 )
Change subject: mediatek/mt8183: Remove unnecessary parentheses ......................................................................
mediatek/mt8183: Remove unnecessary parentheses
Parentheses are unnecessary for conditions like '(a == b) || (c == d)'.
Change-Id: I0c554bf1577b40286f7a51a8fc5804bdbb7c8bd1 Signed-off-by: Yu-Ping Wu yupingso@google.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/35142 Reviewed-by: Julius Werner jwerner@chromium.org Reviewed-by: Huayang Duan huayang.duan@mediatek.corp-partner.google.com Reviewed-by: Angel Pons th3fanbus@gmail.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/soc/mediatek/mt8183/dramc_pi_basic_api.c M src/soc/mediatek/mt8183/dramc_pi_calibration_api.c M src/soc/mediatek/mt8183/rtc.c 3 files changed, 7 insertions(+), 7 deletions(-)
Approvals: build bot (Jenkins): Verified Julius Werner: Looks good to me, approved Angel Pons: Looks good to me, approved Huayang Duan: Looks good to me, approved
diff --git a/src/soc/mediatek/mt8183/dramc_pi_basic_api.c b/src/soc/mediatek/mt8183/dramc_pi_basic_api.c index cdba2af..cb462e9 100644 --- a/src/soc/mediatek/mt8183/dramc_pi_basic_api.c +++ b/src/soc/mediatek/mt8183/dramc_pi_basic_api.c @@ -63,7 +63,7 @@ (sw_impedance[dq_term][0] << 5) | (sw_impedance[dq_term][1] << 0)); clrsetbits_le32(&ch[0].ao.shu[0].drving[1], - (0x1f << 25)|(0x1f << 20) | (1 << 31), + (0x1f << 25) | (0x1f << 20) | (1 << 31), (sw_impedance[dq_term][0] << 25) | (sw_impedance[dq_term][1] << 20) | (!dq_term << 31)); clrsetbits_le32(&ch[0].ao.shu[0].drving[2], (0x1f << 5) | (0x1f << 0), diff --git a/src/soc/mediatek/mt8183/dramc_pi_calibration_api.c b/src/soc/mediatek/mt8183/dramc_pi_calibration_api.c index 05f793e..e8ee818 100644 --- a/src/soc/mediatek/mt8183/dramc_pi_calibration_api.c +++ b/src/soc/mediatek/mt8183/dramc_pi_calibration_api.c @@ -1378,7 +1378,7 @@
static void dramc_set_dqdqs_dly(u8 chn, u8 rank, enum CAL_TYPE type, s32 dly) { - if ((type == RX_WIN_RD_DQC) || (type == RX_WIN_TEST_ENG)) + if (type == RX_WIN_RD_DQC || type == RX_WIN_TEST_ENG) dramc_set_rx_dly(chn, rank, dly); else dramc_set_tx_dly_factor(chn, rank, type, dly); @@ -1553,7 +1553,7 @@ dramc_dbg("[channel %d] [rank %d] type:%d, vref_enable:%d\n", chn, rank, type, vref_scan_enable);
- if ((type == TX_WIN_DQ_ONLY) || (type == TX_WIN_DQ_DQM)) { + if (type == TX_WIN_DQ_ONLY || type == TX_WIN_DQ_DQM) { for (size_t i = 0; i < 2; i++) { write32(&ch[chn].phy.shu[0].rk[rank].b[i].dq[0], 0); clrbits_le32(&ch[chn].phy.shu[0].rk[rank].b[i].dq[1], @@ -1592,7 +1592,7 @@ if (vref_scan_enable) dramc_set_vref(chn, rank, type, vref_dly.vref);
- if ((type == RX_WIN_RD_DQC) || (type == RX_WIN_TEST_ENG)) { + if (type == RX_WIN_RD_DQC || type == RX_WIN_TEST_ENG) { dramc_set_rx_dly_factor(chn, rank, RX_DQM, FIRST_DQ_DELAY); dramc_set_rx_dly_factor(chn, rank, @@ -1666,7 +1666,7 @@ if (vref_scan_enable) dramc_set_vref(chn, rank, type, vref_dly.vref);
- if ((type == RX_WIN_RD_DQC) || (type == RX_WIN_TEST_ENG)) + if (type == RX_WIN_RD_DQC || type == RX_WIN_TEST_ENG) dramc_set_rx_best_dly(chn, rank, vref_dly.perbit_dly); else dramc_set_tx_best_dly(chn, rank, vref_dly.perbit_dly, diff --git a/src/soc/mediatek/mt8183/rtc.c b/src/soc/mediatek/mt8183/rtc.c index af30d1f..f8d81f8 100644 --- a/src/soc/mediatek/mt8183/rtc.c +++ b/src/soc/mediatek/mt8183/rtc.c @@ -177,7 +177,7 @@ /* select 26M as target clock */ val = rtc_get_frequency_meter(middle, PMIC_FQMTR_CON0_FQM26M_CK, 0);
- if ((val >= RTC_FQMTR_LOW_BASE) && (val <= RTC_FQMTR_HIGH_BASE)) + if (val >= RTC_FQMTR_LOW_BASE && val <= RTC_FQMTR_HIGH_BASE) break; if (val > RTC_FQMTR_HIGH_BASE) right = middle; @@ -185,7 +185,7 @@ left = middle; }
- if ((val >= RTC_FQMTR_LOW_BASE) && (val <= RTC_FQMTR_HIGH_BASE)) + if (val >= RTC_FQMTR_LOW_BASE && val <= RTC_FQMTR_HIGH_BASE) return middle;
val = rtc_get_frequency_meter(left, PMIC_FQMTR_CON0_FQM26M_CK, 0);
-
Angel Pons (Code Review) -
Huayang Duan (Code Review)
-
Julius Werner (Code Review)
-
Patrick Georgi (Code Review)
-
Yu-Ping Wu (Code Review)