Attention is currently required from: Intel coreboot Reviewers, Jérémy Compostella, Keith Hui, Nicholas Chin.
Paul Menzel has posted comments on this change by Keith Hui. ( https://review.coreboot.org/c/coreboot/+/86390?usp=email )
Change subject: sb/intel/common: Add GPIO serial blink console support ......................................................................
Patch Set 2:
(6 comments)
Patchset:
PS2: Nice.
File Documentation/technotes/console.md:
https://review.coreboot.org/c/coreboot/+/86390/comment/6460dc4b_e79c432f?usp... : PS2, Line 177: a LED an LED
https://review.coreboot.org/c/coreboot/+/86390/comment/fd9c6ecc_3c35881a?usp... : PS2, Line 178: pulls pull (without s)?
https://review.coreboot.org/c/coreboot/+/86390/comment/a13eede4_f650dc60?usp... : PS2, Line 182: No space.
https://review.coreboot.org/c/coreboot/+/86390/comment/17751906_08e7dfa9?usp... : PS2, Line 183: to base your circuit off of Sounds strange, but I am no native speaker.
File src/console/Kconfig:
https://review.coreboot.org/c/coreboot/+/86390/comment/2ddef560_6cc498cc?usp... : PS2, Line 405: an a