Attention is currently required from: Dinesh Gehlot, Kapil Porwal, Nick Vaccaro, Subrata Banik.
Ronak Kanabar has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80274?usp=email )
Change subject: soc/intel/alderlake: select UDK_202111_BINDING for ADL-N
......................................................................
Patch Set 5:
(1 comment)
File src/soc/intel/alderlake/Makefile.mk:
https://review.coreboot.org/c/coreboot/+/80274/comment/8fd75e5f_cb097b07 :
PS4, Line 72:
: ifeq ($(CONFIG_SOC_INTEL_ALDERLAKE_PCH_N),y)
: CFLAGS_common += -fshort-wchar
: endif
please specify the reason behind this change. […]
I have added the reason in comment. change the check to UDK_202111_BINDING any ADL platform which uses EDK2 202111 will have -fshort-wchar in compilation.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/80274?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: If277ede4307515035389cd0e9d34c15cc80f278c
Gerrit-Change-Number: 80274
Gerrit-PatchSet: 5
Gerrit-Owner: Ronak Kanabar
ronak.kanabar@intel.com
Gerrit-Reviewer: Dinesh Gehlot
digehlot@google.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Dinesh Gehlot
digehlot@google.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Comment-Date: Thu, 07 Mar 2024 10:05:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com
Gerrit-MessageType: comment