[S] Change in coreboot[master]: mb/google/rex: Add PCIe based SD controller - coreboot-gerrit

29 Nov 2022


      Attention is currently required from: Tarun Tuli, Kapil Porwal, Ivy Jian.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/70064 )
Change subject: mb/google/rex: Add PCIe based SD controller
......................................................................
Patch Set 2:
(1 comment)
File src/mainboard/google/rex/variants/rex0/gpio.c:
https://review.coreboot.org/c/coreboot/+/70064/comment/592af4ad_cd3a3fcf 
PS2, Line 434: static const struct pad_config romstage_gpio_table_id0[] = {
...
Will we increase board_id to 1 or keepping 0 for proto 1 ?, I see b/245158908#comment13 from YH, BOARD_VERSION: 1
Good point @Ivy, can you please create a bug and assign to me ?
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/70064
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I23d53e4d61ec36d2145f9e5816d97d13eb5b219e
Gerrit-Change-Number: 70064
Gerrit-PatchSet: 2
Gerrit-Owner: Subrata Banik subratabanik@google.com
Gerrit-Reviewer: Eric Lai eric_lai@quanta.corp-partner.google.com
Gerrit-Reviewer: Ivy Jian ivy.jian@quanta.corp-partner.google.com
Gerrit-Reviewer: Kapil Porwal kapilporwal@google.com
Gerrit-Reviewer: Tarun Tuli taruntuli@google.com
Gerrit-Attention: Tarun Tuli taruntuli@google.com
Gerrit-Attention: Kapil Porwal kapilporwal@google.com
Gerrit-Attention: Ivy Jian ivy.jian@quanta.corp-partner.google.com
Gerrit-Comment-Date: Wed, 30 Nov 2022 07:30:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Ivy Jian ivy.jian@quanta.corp-partner.google.com
Gerrit-MessageType: comment