Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/25019 )
Change subject: lib: Add FIT payload support
......................................................................
Patch Set 37:
(1 comment)
https://review.coreboot.org/c/coreboot/+/25019/37/src/lib/fit_payload.c
File src/lib/fit_payload.c:
https://review.coreboot.org/c/coreboot/+/25019/37/src/lib/fit_payload.c@45
PS37, Line 45: * Returns true on error, false on success.
Patrick, This was just pointed out in another commit. Maybe add a comment as to WHY it was done this way, because this is not what's expected.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/25019
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0f27b92a5e074966f893399eb401eb97d784850d
Gerrit-Change-Number: 25019
Gerrit-PatchSet: 37
Gerrit-Owner: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: David Hendricks
david.hendricks@gmail.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Aaron Durbin
adurbin@chromium.org
Gerrit-CC: Martin Roth
martinroth@google.com
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-CC: Patrick Rudolph
Gerrit-Comment-Date: Sun, 04 Aug 2019 15:07:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment