Attention is currently required from: Furquan Shaikh, Tim Wawrzynczak, Angel Pons, Patrick Rudolph. Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55330 )
Change subject: soc/intel/tigerlake: Make use of is_devfn_enabled() function ......................................................................
Patch Set 2:
(7 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/55330/comment/1acc35f7_8dda0420 PS1, Line 15: built
nit: build
Ack
https://review.coreboot.org/c/coreboot/+/55330/comment/f227532b_4700a456 PS1, Line 17:
nit: Drop blank line?
Ack
File src/soc/intel/tigerlake/fsp_params.c:
https://review.coreboot.org/c/coreboot/+/55330/comment/325a3091_4f14f7ef PS1, Line 266: dev->enabled = 0;
This also disabled the device in the devicetree
Ack
https://review.coreboot.org/c/coreboot/+/55330/comment/0e36023b_0a02e0fa PS1, Line 345: SA_DEVFN_VMD
SA_DEVFN_THC0
Ack
https://review.coreboot.org/c/coreboot/+/55330/comment/9b226e80_49320474 PS1, Line 346:
nit: Drop blank line?
Ack
File src/soc/intel/tigerlake/romstage/fsp_params.c:
https://review.coreboot.org/c/coreboot/+/55330/comment/8e2d976f_dfb4333d PS1, Line 114:
nit: Drop blank line?
Ack
https://review.coreboot.org/c/coreboot/+/55330/comment/55cf2eb3_0da9e2ea PS1, Line 117: : m_cfg->TcssItbtPcie0En = is_devfn_enabled(SA_DEVFN_TBT0); : : m_cfg->TcssItbtPcie1En = is_devfn_enabled(SA_DEVFN_TBT1); : : m_cfg->TcssItbtPcie2En = is_devfn_enabled(SA_DEVFN_TBT2); : : m_cfg->TcssItbtPcie3En = is_devfn_enabled(SA_DEVFN_TBT3);
nit: Drop blank lines in between?
Ack