Attention is currently required from: Nick Vaccaro, Subrata Banik.
Dtrain Hsu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/77538?usp=email )
Change subject: mb/google/nissa/var/uldren: Remove fw_config probe for TS and TP ......................................................................
Patch Set 6:
(2 comments)
Patchset:
PS6:
Also consider server center can set FW config for TP to unknown? Can that work?
Preventing service center forget to set fw_config, remove fw_config probe for TS and TP is better.
PS6:
The ap log is from local build nissa branch, ``` [INFO ] _SB.PCI0.I2C0.TPMI: I2C TPM at I2C: 00:50 [SPEW ] I2C TX abort detected (00000001) [SPEW ] _SB.PCI0.I2C1.H02C: WDT Touchscreen at I2C: 00:2c -- NOT FOUND, skipping [SPEW ] I2C TX abort detected (00000001) [SPEW ] _SB.PCI0.I2C1.D010: ELAN Touchscreen at I2C: 00:10 -- NOT FOUND, skipping [INFO ] _SB.PCI0.I2C1.H016: ELAN Touchscreen at I2C: 00:16 [SPEW ] I2C TX abort detected (00000001) [SPEW ] _SB.PCI0.I2C1.H05D: Goodix Touchscreen at I2C: 00:5d -- NOT FOUND, skipping [SPEW ] I2C TX abort detected (00000001) [SPEW ] _SB.PCI0.I2C1.H040: G2TOUCH Touchscreen at I2C: 00:40 -- NOT FOUND, skipping [SPEW ] I2C TX abort detected (00000001) [SPEW ] _SB.PCI0.I2C1.H03C: WDT Touchscreen at I2C: 00:3c -- NOT FOUND, skipping [INFO ] _SB.PCI0.I2C3.CRUS: Cirrus Logic CS42l42 Audio Codec address 048h irq 0 [SPEW ] I2C TX abort detected (00000001) [SPEW ] _SB.PCI0.I2C5.D015: ELAN Touchpad at I2C: 00:15 -- NOT FOUND, skipping [INFO ] _SB.PCI0.I2C5.H02C: Goodix Touchpad at I2C: 00:2c ```