Change in coreboot[master]: acpigen: Fix incorrect write calls - coreboot-gerrit

25 Jan 2021


      Attention is currently required from: Lance Zhao, Paul Menzel, Duncan Laurie.
jacz@semihalf.com has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49834 )
Change subject: acpigen: Fix incorrect write calls
......................................................................
Patch Set 2:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/49834/comment/24255d03_72cc3f5a 
PS2, Line 12:
...
Did some unit test find this?
No. I found that when reading acpi/acpigen.c. Calls were not matching function name (I think they should have) and there was no comment stating, why it was made this way. I assumed this was a mistake.
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/49834
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I116fd41624a8e8b536d18d747f21d3131b734dfc
Gerrit-Change-Number: 49834
Gerrit-PatchSet: 2
Gerrit-Owner: jacz@semihalf.com
Gerrit-Reviewer: Duncan Laurie dlaurie@chromium.org
Gerrit-Reviewer: Frans Hendriks fhendriks@eltan.com
Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr
Gerrit-Reviewer: Lance Zhao
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Attention: Lance Zhao
Gerrit-Attention: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Attention: Duncan Laurie dlaurie@chromium.org
Gerrit-Comment-Date: Mon, 25 Jan 2021 11:39:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-MessageType: comment